🇬🇧United Kingdom @Ashley George

Account created on 24 June 2014, over 10 years ago
#

Recent comments

🇬🇧United Kingdom Ashley George

The patches for this stopped working for us after a recent module update. Inspecting the most recent patch version (under issue fork - plain diff), I can see that most of the changes are now in the module.

🇬🇧United Kingdom Ashley George

Actually I'm not quite right with my description of how it's behaving now, but it's still not correct. If someone could see if they can replicate that would be awesome.

🇬🇧United Kingdom Ashley George

@smustgrave unfortunately this doesn't seem to resolve things. After implementing the change suggested by @shiv_yadav the visibility on "select3" is now only linked to "select1". So I beleive there is still a valid issue here.

🇬🇧United Kingdom Ashley George

I realised I needed to do something similar to the noscript output of this module.

🇬🇧United Kingdom Ashley George

I realise I accidentally included a change from a seperate patch which altered the script to use 'defer' rather that 'async'. Here's an update without that.

🇬🇧United Kingdom Ashley George

I was finding that the with Matteo's patch the ampersands in the GTM script were being rendered as encoded (&).

I notice that when the html_tag was being rendered, it was being run through a sanitising function before setting that new value as the eventual markup.

In our module, if you set the #value of the html_tag as markup then it bypasses the sanitisation.

I'm not sure if this is the right thing to do but it allowed us to move forward.

Production build 0.71.5 2024