- Issue created by @utkarsh_33
- Merge request !721#3505700: Move the Project browser specific styling from gin theme to project browser's scope. → (Merged) created by utkarsh_33
- 🇮🇳India utkarsh_33
Once we verify that the changes are we can ask the Gin theme maintainers to remove the styles from gin theme.I'll mark it NR and will request @chrisfromredfin or @phenaproxima to take further decisions.
- 🇮🇳India utkarsh_33
Also adding Status icon and maintenance icon are of different size in Gin theme. 🐛 Status icon and maintenance icon are of different size in Gin theme. Active for reference as this was brought up from the comment.
I think this will also make things more simpler for The Svelte code should not have custom logic for the Gin theme 🐛 The Svelte code should not have custom logic for the Gin theme Active if i am not wrong. - 🇺🇸United States phenaproxima Massachusetts
Doesn't seem problematic to me, although I do have one question. Also, certain lint checks are failing, so kicking this back for that.
I think we might want to wait until Gin removes their styling and tags a new release (I can ask @saschaeggi to do this), and then we can conflict with any version of Gin older than that one.
- 🇮🇳India utkarsh_33
Loading the CSS related to Gin conditionally as requested.Also the CI is Green so marking it NR again.
- 🇺🇸United States phenaproxima Massachusetts
I think that looks pretty good, just a few small changes.
- 🇨🇭Switzerland saschaeggi Zurich
Please see https://git.drupalcode.org/project/gin/-/merge_requests/588 in Gin 📌 Remove Project Browser-specific styling Active
- 🇺🇸United States phenaproxima Massachusetts
Postponing on 📌 Remove Project Browser-specific styling Active .
- 🇺🇸United States phenaproxima Massachusetts
Let's get this up to date and conflict with any version of Gin older than 4.0.6.
- 🇨🇭Switzerland saschaeggi Zurich
Let me know if anything else is needed to get this over the finish line 🤝
- 🇺🇸United States phenaproxima Massachusetts
This seems to work as intended with Gin 4.0.6, but the new drop-button alignment isn't great:
I would not consider this a blocker, but maybe we can quick-fix this now.
- First commit to issue fork.
-
chrisfromredfin →
committed 399a0cd0 on 2.0.x authored by
utkarsh_33 →
Issue #3505700 by phenaproxima, utkarsh_33, saschaeggi: Move the Project...
-
chrisfromredfin →
committed 399a0cd0 on 2.0.x authored by
utkarsh_33 →
- 🇺🇸United States chrisfromredfin Portland, Maine
That'll do pig, that'll do.
Automatically closed - issue fixed for 2 weeks with no activity.