- Issue created by @phenaproxima
- Merge request !700Start working towards removing Gin-specific hacks in the JS → (Closed) created by phenaproxima
- 🇺🇸United States phenaproxima Massachusetts
Started this but wasn't quite able to remove all mentions of Gin from the Svelte code, since we're also using it to conditionally apply classes to elements. Not entirely sure how to approach fixing that.
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
Unfortunately, I don't think switching from
'gin' in drupalSettings
toGIN_ENABLED
gains us anything -- the problem still exists, which is that we are conditionally applying classes based on the presence of the Gin theme. We need to not do that. The goal is for the Svelte code to not mention or care about Gin at all.Let's maybe talk through the CSS cascade here and see what we can do about it.
- Merge request !769#3503140: The Svelte code should not have custom logic for the Gin theme → (Merged) created by utkarsh_33
- 🇺🇸United States phenaproxima Massachusetts
Couple of questions but this seems like a big improvement to me.
- 🇮🇳India utkarsh_33
I have moved the css related to
Gin
into it's specific file.This is ready for review. - 🇺🇸United States phenaproxima Massachusetts
Should probably get some manual testing but I think this looks like great and worthwhile cleanup!
-
tim.plunkett →
committed b862028b on 2.0.x authored by
utkarsh_33 →
Issue #3503140 by utkarsh_33, phenaproxima: The Svelte code should not...
-
tim.plunkett →
committed b862028b on 2.0.x authored by
utkarsh_33 →
Automatically closed - issue fixed for 2 weeks with no activity.