- Issue created by @utkarsh_33
- Merge request !717#3505450: Status icon and maintenance icon are of different size in Gin theme. → (Open) created by utkarsh_33
- 🇮🇳India utkarsh_33
Not sure if the fix is robust enough but it definitely solves the problem.Marking it NR for opinions.
- 🇺🇸United States phenaproxima Massachusetts
🤔
From the IS:
web/themes/contrib/gin/dist/css/components/project_browser.css
So Gin already has Project Browser-specific styling? To me, that says we should fix Gin-related styling problems upstream in Gin, rather than us adding Gin-specific CSS. Maybe we should move this issue to Gin's queue?
That could also be a useful direction for issues like 🐛 The Svelte code should not have custom logic for the Gin theme Active .
- 🇺🇸United States phenaproxima Massachusetts
OK, well, I'm tentatively RTBCing this since the code itself looks fine, but I would like it to be confirmed in manual testing by someone familiar with the look and feel that is desired here.
If that can't happen, for some reason, then a before/after screenshot pair would be ideal.
- 🇺🇸United States chrisfromredfin Portland, Maine
I'm not sure if this is really Needs Work or actually if it should be Closed (CNR).
I cannot reproduce the original issue in 2.0.x with Gin 4.0.4. I've tried in DrupalPod, and applying this MR actually causes the first icon to grow bigger than its neighbor.
Leslie confirmed this. I confirmed with a local install of 2.0.x HEAD as of 3p EST Feb 18 (5f0ee417).
With that said, both of our icons have a `width: 24px` set on them by default, so I would really think this is a bug in Gin, if it is in fact reproducible with some particular version.
???
- 🇮🇳India utkarsh_33
I can still reproduce the problem on my local atleast.But i think this can be Postponed on https://www.drupal.org/project/project_browser/issues/3505700, as this will make easier to handle the css issues.
I am still attaching the SS for how it looks on my local.The version of Gin i am using in "3.1.0". - 🇺🇸United States phenaproxima Massachusetts
Postponing on 📌 Move the Project browser specific styling from gin theme to project browser's scope. Active .