PHPUnit tests: Support form actions being outside of a form

Hi,

I was blocked when trying to implement tests on a custom project which is using Gin.

I copied the submitForm method from the MR in the tests of my project and now it is working.

Would it be possible to make it a trait please?

Thanks!

Uploading patch for composer usage.

This looks sensible and doesn't break any existing tests. However is there a minimal implementation of the form button being outside the form we could implement in a test module so that we could add coverage for it to BrowserTestBaseTest?

Added tests to go along, since all changes are in tests, the Gitlab "Test Only" runner still passed haha, so just for the sake of it, here's a "Test only" patch omitting the UI helper changes to show the failure.

I have tested the issue & it's replicable on local

Test both test scenario pass & fail & attached the screenshots for reference:

A. Keep the newly added test code on local , but not fixation code: issue replicable (test fail)

B. Keep the newly added test code on local , also added fixation code: issue fixed (test pass)

RTBC++1, also reviewed test code , written with minimal required changes

@ pooja_sharma

Can you clarify what you are splitting into the fix code vs test code?

@nicxvan it's explained in #12, because the code is all part of tests, the test-only gitlab test will always pass, so @pooja_sharma used my test-only patch which is the actual new test to show fail, and then combined the entire MR (the bugfix) to show pass

Yeah, Thanks @b_sharpe you got it right. , however for the clarity, @nicxvan I have updated comment.

Ah I missed the test only patch, that's why I was confused. Thanks for clarifying.

I havent reviewed the test, but can say the associated changes resolve tests where the Gin interface is involved. Particularly form submissions, resulting in the failure:

Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "./ancestor::form" not found.

Thanks!

Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies. Also, 10.2 is in security mode now.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

As prev MR has some unrelated 1000+ additional change, it seems MR got corrupted.

Raised new MR 8838 with related changes only, against 11.x dev target branch

For testing I have already added detail comments along with attached the screenshots in #14 ✨ PHPUnit tests: Support form actions being outside of a form Active

Not sure which MR is up for review.

Can one be hidden please and whichever one is it be pointed to 11.x?

Discussed this with @tim.plunkett and it's not clear how this is a stable blocker for Drupal CMS. Removing the tag until we have more clarity on that.

Good news I think we can close this now as with RC14 we overhauled this and it doesn't seem to be needed anymore.

If needed, I'll reopen it later again.

This isnt just a Gin problem, we can de-escalate, but it still seems necessary to adhere to standards.

Isn't this only a testing issue? Moving to phpunit but if there's more to it, could use an issue summary update.