- Issue created by @phenaproxima
- 🇮🇳India utkarsh_33
As #3505700: Move the Project Browser-specific styling from Gin is in so we can start working on this.Marking it active.
- Merge request !771#3509162: Removed usage of #project-browser with more specific classes → (Open) created by utkarsh_33
- 🇮🇳India utkarsh_33
I have removed most of the #project-browser usage.The remaining are hard to remove because they are direct child of #project-browser.
Attaching the SS for the same which shows the HTML structure for this. - 🇮🇳India utkarsh_33
@saschaeggi do you have any better way to handle the remaining stuff?
- Status changed to Needs review
about 1 month ago 4:13pm 8 July 2025 - 🇺🇸United States chrisfromredfin Portland, Maine
Is our compatibility with Gin all sewn up and this can be closed? Or is this work still needed?
- 🇺🇸United States phenaproxima Massachusetts
I think the code changes look fine, but I'm not really qualified to sign off on them.
- 🇺🇸United States chrisfromredfin Portland, Maine
The initial code changes here are a good start, in that we want to remove #project-browser as a selector now that we can have multiple per page.
BUT, the original intent of factoring some of our colors, etc out into custom properties is not even started. I think I will drop this in the "nice-to-haves" for stable release, but certainly not required. Our compatibility with Gin is really solid as it stands, even if it's not perfect.
- 🇮🇳India anirudhsingh19
I have added a class named project-browser__wrapper in the template and replaced #project-browser in css with it. Moving to NR, Please review!!
- 🇮🇳India anirudhsingh19
There's some issue coming with MR. All the commits from 2.1.x has been added.
- 🇮🇳India anirudhsingh19
anirudhsingh19 → changed the visibility of the branch 2.0.x to hidden.
- 🇮🇳India anirudhsingh19
anirudhsingh19 → changed the visibility of the branch 3509162-refactor-project-browsers to hidden.
- 🇮🇳India anirudhsingh19
anirudhsingh19 → changed the visibility of the branch 3509162-refactor-css-to-control-colors to hidden.
- Merge request !866Issue #3509162: Refactor Project Browser's styling so that it uses CSS... → (Open) created by Unnamed author
- 🇮🇳India anirudhsingh19
Had to make a new branch as all the commits from upstream 2.1.x had been added to previous branches, cherrypicked all the earlier commits in this branch. Apologies for so much noise.
- 🇺🇸United States phenaproxima Massachusetts
You can just edit the merge request and have it target 2.1.x directly, rather than cherry-picking all the commits. I'll open a new MR that has a clean history. This issue should have been switched to 2.1.x before it was reassigned, apologies for that.