- Issue created by @tanmayk
- Status changed to Closed: works as designed
9 months ago 5:57pm 3 March 2024 - 🇨🇭Switzerland saschaeggi Zurich
I'm closing this as we moved it out of the head for security (CSP) reasons.
If you use aggregation the switch should be barely visible. Maybe in the future we can generate a CSS file but for now we'll keep it as-is as we have other priorities and no functionality is impacted here.
Cheers!
- Status changed to Active
9 months ago 3:55pm 4 March 2024 - 🇺🇸United States mglaman WI, USA
CSP blocks inline styles? Why couldn't it add a
style
tag to the head? Changing from a bug to a feature given it's not being considered a bug. The feature request being a refactor from JavaScript based injection to an inline style declaration. - Status changed to Postponed
9 months ago 5:07pm 4 March 2024 - 🇨🇭Switzerland saschaeggi Zurich
Moving this to a feature request sounds good to me.
There were (strong) arguments against it back in the day and thus we have changed the implementation towards the JS solution but I'll have to find them as it has been a while 😅
Moving this to backlog for now, if anyone wants to pick it up in the meantime feel free to do so. Just make sure we don't break the live preview feature in settings.
- 🇺🇸United States mglaman WI, USA
Thanks saschaeggi! We may workaround it on our end but I'd like to push a patch. Also, good to know about the live preview. We could have the JS update the existing style element if it exists or insert if not.
- Merge request !3923424925 - Removed color flicker when custom accent color is used. → (Open) created by tanmayk
- 🇺🇸United States mglaman WI, USA
We've got an MR open. I'll move away from Postponed once its been reviewed and worked a bit more. But we're using this code.
- 🇺🇸United States mglaman WI, USA
I wonder if ✨ Provide a parser for THEME.colors.yml Needs work will make this easier. If anything, it should provide the helper class for shading.