custom JS dropdown is obscured

Created on 15 May 2025, 8 days ago

Problem/Motivation

Module Builder uses a custom JS dropdown for its hook implementation names.

However, in Gin most of this gets obscured by the rest of the form

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joachim
  • 🇨🇭Switzerland saschaeggi Zurich

    Thanks for reporting Joachim, I'm moving this one to the Module builder issue queue instead

  • 🇬🇧United Kingdom joachim

    This is not a Module Builder bug -- as you can see in the screenshot, it works fine in Claro.

  • 🇨🇭Switzerland saschaeggi Zurich

    I've seen the screenshots that it works in Claro. I'd still want the Module builder team first having a look if they can fix it on their end as we're hesitant to add any further custom code for modules at this point to Gin. We'll actually deprecate a lot of the custom module code in Gin soon and will push for the modules to directly include the code as it's not really maintainable on our end.

    So I'm moving this once more so the Module builder team can have a look at this 😊

  • 🇬🇧United Kingdom joachim

    The Module Builder team is me. I built that UI.

    > as we're hesitant to add any further custom code for modules at this point to Gin.

    I'm not asking for special treatment. You're presumably doing something weird with CSS which is breaking things.

  • 🇬🇧United Kingdom joachim

    It's something done by the classes

    > gin-table-scroll-wrapper gin-horizontal-scroll-shadow syncscroll

    on the DIV around the table.

    If I remove those classes in the browser developer tools, the problem is fixed.

  • 🇨🇭Switzerland saschaeggi Zurich

    You're presumably doing something weird with CSS which is breaking things.

    Nice accusation, thank you.

    > gin-table-scroll-wrapper gin-horizontal-scroll-shadow syncsc

    Without looking too deep into Module builders code , If you change this line to fixed, would it work? (There might be additional changes needed, too like setting top when changed to fixed)

    https://git.drupalcode.org/project/module_builder/-/blob/4.0.x/css/compo...

    See example: https://codepen.io/saschaeggi/pen/RNNdrro

    I hope this helps

  • 🇬🇧United Kingdom joachim

    I'm not sure where you mean I should put 'fixed', but I can't change the classes on that element -- they're coming from the template in Gin.

    I've narrowed the problem down to these two overflow properties:

    .gin-table-scroll-wrapper {
      clear: both;
      overflow-x: auto;  <--
      overflow-y: hidden; <--
    
  • 🇨🇭Switzerland saschaeggi Zurich

    Like I mentioned above it needs to be fixed in Module builder, if you click on the link it will lead you to the line you'll need to change.

    I'm moving this back to module builder

    I also provided you a codepen above

Production build 0.71.5 2024