Tags td, tr or th ignored by new parseHTML implementation

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

@alexdoma to output with html tags you need to add the

@anjaliprasannan
i have checked your example and get the same results as you.

But, in your html output additional '

Ok I tried with

$response->addCommand(new ReplaceCommand('#ajax-message', '<table><td>Hello!</td></table>'));

this removed the additional tr. Are you giving the proper selector to replace?

PLease, read whole message i have wrote my test case 2 times.
I have provided correct test case with an error.

I don`t want to replace full table like in your case. I want to replace one cell.
Case for one cell is not working.

P.S. in your test case you missed closing </tr> thats why you have 2 rows.

Replace one cell not working.

// Not working.
$ajax_response->addCommand(new ReplaceCommand($selector, '<td>Hello!</td>')); 

Replace one table working.

// Working.
$ajax_response->addCommand(new ReplaceCommand($selector, '<table><tr><td>Hello!</td></tr></table>'));

yes I understand, I am checking.

@alexdoma, Please use this

$response->addCommand(new HtmlCommand('#replace-me', '<td>Hello</td>'));

before replace

After replace

@nod_ @quietone
@anjaliprasannan Thank you for your feedback. But i think you have provided incorrect example.

Upon encountering this error for the first time, I also came to the conclusion that using HtmlCommand would be the best solution. However, I have a large number of places in my code where I use ReplaceCommand

The desire to get rid of the jQuery library is commendable, but not at any cost.

Frankly, I don’t understand why I should rewrite my code because of a bug in the core. I haven’t seen any updates in the documentation for ReplaceCommand indicating that it doesn't work for certain tags.

I believe the parent issue (#3238870 Refactor (if feasible) use of jquery parseHTML function to use vanillaJS) was resolved incorrectly and it needs to be reopened. In the meantime, the changes should be reverted.

any updates?

I tried with RemoveCommand then using AppendCommand, that too returned as ReplaceCommand. So there is issue in core which needs to be fixed.

Not sure when I gave feedback about this issue. looking at the difference between jQuery and our code, they have a shortcut when a single element is parsed, which we didn't replicate.

I like the template solution, we should try it out and see if the tests are green. We might need an additional test to make sure we don't break this again.

As for revert, given that this code has been shipped in several minor and major releases for over half a year, It's easier to fix it here and ship the fix in the next release. Nobody should have to rewrite their code because of this change, otherwise there'd be a change record attached to the issue.

Created the MR with the described changes.
I suppose it will require additional tests, maybe some code comments updates but I hope it is OK to have it as the first step and see what the tests results will say.

The first attempt has broken the behaviors attachment. Thanks @reinfate for spotting and fixing it.
Hope this time it works.

To avoid breaking this in the future probably best to add test coverage for the issue.

Rebased the MR
Added tests for the tr element.

Tests are green and test only changes failed as expected.

Removing the tests tag as the test-only job was ran here https://git.drupalcode.org/issue/drupal-3504582/-/jobs/5727938 and gave

Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testInsertAjaxResponse
Page contains expected value: <div class="ajax-target-wrapper"><table><tbody id="ajax-target"><tr><td>table-row</td></tr></tbody></table></div>
Failed asserting that fals

Would probably want sub-maintainer to give thumbs up too

good to go, thanks

nod_ → closed merge request !11277

Committed and pushed fa5980671e2 to 11.x and 09b2afc5921 to 11.2.x and 036463a2eb7 to 10.6.x and 1ed197bc9df to 10.5.x. Thanks!