Refactored the module's code to avoid errors.
Also removed unrelevant log message.
See the MR #1
artem_sylchuk → made their first commit to this issue’s fork.
artem_sylchuk → created an issue.
artem_sylchuk → made their first commit to this issue’s fork.
artem_sylchuk → created an issue.
artem_sylchuk → made their first commit to this issue’s fork.
Makes sense, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Looks good, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
I'm not sure if that's relevant, but MultichoiceQuestion::save() calls
parent::save();
$this->forgive();
$this->warn();
the parent::save method stores the max-score of the question as is (0) and then the "forgive" that sets the max-score per alternative based on the "correct" checkbox. that change was added in https://git.drupalcode.org/project/quiz/-/commit/2c48eea (the D7 comment was saying that we need to "forgive" before saving, it was changed to "after": #3198222: Quiz results score ignores simple question option → )
bohart → credited artem_sylchuk → .
That worked perfectly for me, thanks!
bohart → credited artem_sylchuk → .
Thanks for catching that, fix is merged.
However the code there is confusing, the thread entity seems to be stored in the formState several times with different names, I think I'll create another issue for cleaning that up.
artem_sylchuk → made their first commit to this issue’s fork.
Nice catch! Thank you, merged.
artem_sylchuk → made their first commit to this issue’s fork.
Closed, thanks
That should be enough for now I think, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Awesome, thank you!
artem_sylchuk → made their first commit to this issue’s fork.
Private message had a config to hide the format selection that was confusing people.
That setting is removed now as preferable way to handle this is to use Drupal core configuration:
https://www.drupal.org/node/3318572 →
For core versions prior 10.1 the
https://www.drupal.org/project/allowed_formats →
had to be used.
Using WYSIWYG editors and allowing different media for drupal default textare is a topic of a basic Drupal configuration and isn't specific for Private Message as module uses the generic field type for it.
artem_sylchuk → made their first commit to this issue’s fork.
artem_sylchuk → made their first commit to this issue’s fork.
Thanks!
artem_sylchuk → made their first commit to this issue’s fork.
artem_sylchuk → made their first commit to this issue’s fork.
Thanks!
Let's get this finally merged
Thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Drupal 9 is no longer supported so I think we can safely move drush services deifinition to the general services.yml file.
artem_sylchuk → made their first commit to this issue’s fork.
Thank you for updating that code!
artem_sylchuk → made their first commit to this issue’s fork.
Good catch, thanks for your massive work!
artem_sylchuk → made their first commit to this issue’s fork.
Looks good for me, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
I hope that additional mesage on the module install will help to not miss the needed steps of the module configuration. The readme already contains mention of the needed steps.
artem_sylchuk → made their first commit to this issue’s fork.
Awesome, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Looks good, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Hope that will help
artem_sylchuk → made their first commit to this issue’s fork.
Awesome work, thank you guys!
Looks good, thanks!
Merged, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Thanks for checking that, marking as fixed
Awesome work! Merged, thanks!
artem_sylchuk → changed the visibility of the branch 8.x-2.x to hidden.
Looks good, thanks!
artem_sylchuk → made their first commit to this issue’s fork.
Thank you, looks good for me, merged.
artem_sylchuk → made their first commit to this issue’s fork.
Its mergable with latest dev (at least gitlab says so), however it brings massive UX change and upgrade path is questionable so it is doubtable that I'll merge it the way it is now. However I think eventually having 2 separate private message types is the proper way to go.
artem_sylchuk → made their first commit to this issue’s fork.
artem_sylchuk → changed the visibility of the branch 2942602-unable-to-create to hidden.
Going to review this, however I see that at least at one place the context passed to once() is wrong
I suppose there is no more to fix here. Except some documentation maybe
It seems it is already fixed in 3.x
Can't reproduce on the recent version of the module.
Code referenced here is no longer present in the supported branch.
That is doable with using some of the drupal apis (defining a route in a custom module + some preprocess functions), however I don't think it is still relevant after 5 years.
No chance for this to happen anytime soon.
Don't think it is still relevant after the 5+ years.
1.x won't receive any more updates.
I believe it is fixed in 3.x
Don't think it is happening anytime soon
1.x isn't going to receive any updates.
Unfortunately 1.x is no longer supported and I'm not sure if anything of that can be easily used in 3.x. CLosing as outdated