🇺🇦Ukraine @artem_sylchuk

The first attempt has broken the behaviors attachment. Thanks @reinfate for spotting and fixing it.
Hope this time it works.

Created the MR with the described changes.
I suppose it will require additional tests, maybe some code comments updates but I hope it is OK to have it as the first step and see what the tests results will say.

artem_sylchuk → made their first commit to this issue’s fork.

The service declaration can be simplified as autowire is set to true globally for all services.

The service declaration can be simplified as autowire is set to true globally for all services.

The service declaration can be simplified as autowire is set to true globally for all services.

The service declaration can be simplified as autowire is set to true globally for all services.

Thanks for the review!
I've pushed updates to the views hooks MR, but I'm unsure when I'll get to others.
Having each hooks group in a separate issue may not be ideal as it will produce merge conflicts, but it looked too big for me to have a single MR.
Probably, the rest of the issues should be put into postponed status and merged one by one after they are fixed.

The tests have failed, need to review and fix that.

I think it would be great to add a simple test that checks those links.

The fix is provided in 🐛 Error occurs after adding the private message link to the user display Active

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

The tests have passed, however, I'm not sure if we have any tests for the views integration so probably would be great to check if that works fine for Drupal 10.3+

artem_sylchuk → created an issue.

artem_sylchuk → created an issue.

I tested different formats. SVG and PNG look fine, however, other formats don't.

The HTML div format can be fixed by adding the
.barcode-ean13 .value {position:relative}

And for "binary string" and "Unicode string" it may not make sense to output the code value.
Probably, we should have a note about that on the formatter settings.

Also, #3022641: EAN13 extended code not shown → didn't change the output format to SVG in the template, it looks like it was that way from the very beginning, the other templates were updated in #3025572: Image barcode → but not the EAN-13 for some reason.

Another note is that the code value still doesn't look perfect, even for the SVG, it requires CSS adjustments for different code dimensions.
I've tried to put the code over an image using PHP but it also requires a lot of work for proper positioning, plus it depends on fonts installed on the system so I gave up the idea and switched to bwip-js instead for my project.

Working on it as part of #LutskGCW25

artem_sylchuk → created an issue.

I don't remember the exact history of this issue, but as long as it was bumbed, here is what I remember:
1. It is impossible to force the uniqueness of a thread for a given set of members. For example, if user 1 and user 2 have a thread and there is another thread between user 1, user 2, and user 3, by simply removing user 3 from the site, we'll create a collision. There are other possible cases.
2. It may make sense to have two separate things: private conversations between two users and chats with multiple members. Those can be bundles of private message threads, with different "unique" policies.
3. There is another request and "feature" that we probably may want. The thread uniquness may depend on something else except the thread members. For example, it can be limited by some node that references the thread. The idea was to have getThreadEntityForMembers event that can be used for overriding the thread, but it lacks the context.

Refactored the module's code to avoid errors.
Also removed unrelevant log message.
See the MR #1

artem_sylchuk → made their first commit to this issue’s fork.

artem_sylchuk → created an issue.

artem_sylchuk → made their first commit to this issue’s fork.

artem_sylchuk → created an issue.

artem_sylchuk → made their first commit to this issue’s fork.

Makes sense, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Looks good, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

I'm not sure if that's relevant, but MultichoiceQuestion::save() calls

    parent::save();
    $this->forgive();
    $this->warn();

the parent::save method stores the max-score of the question as is (0) and then the "forgive" that sets the max-score per alternative based on the "correct" checkbox. that change was added in https://git.drupalcode.org/project/quiz/-/commit/2c48eea (the D7 comment was saying that we need to "forgive" before saving, it was changed to "after": #3198222: Quiz results score ignores simple question option → )

bohart → credited artem_sylchuk → .

That worked perfectly for me, thanks!

bohart → credited artem_sylchuk → .

Thanks for catching that, fix is merged.
However the code there is confusing, the thread entity seems to be stored in the formState several times with different names, I think I'll create another issue for cleaning that up.

artem_sylchuk → made their first commit to this issue’s fork.

Nice catch! Thank you, merged.

artem_sylchuk → made their first commit to this issue’s fork.

Closed, thanks

That should be enough for now I think, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Awesome, thank you!

artem_sylchuk → made their first commit to this issue’s fork.

Private message had a config to hide the format selection that was confusing people.
That setting is removed now as preferable way to handle this is to use Drupal core configuration: https://www.drupal.org/node/3318572 →
For core versions prior 10.1 the https://www.drupal.org/project/allowed_formats → had to be used.

Using WYSIWYG editors and allowing different media for drupal default textare is a topic of a basic Drupal configuration and isn't specific for Private Message as module uses the generic field type for it.

artem_sylchuk → made their first commit to this issue’s fork.

artem_sylchuk → made their first commit to this issue’s fork.

Thanks!

artem_sylchuk → made their first commit to this issue’s fork.

artem_sylchuk → made their first commit to this issue’s fork.

Thanks!

Let's get this finally merged

Thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Drupal 9 is no longer supported so I think we can safely move drush services deifinition to the general services.yml file.

artem_sylchuk → made their first commit to this issue’s fork.

Thank you for updating that code!

artem_sylchuk → made their first commit to this issue’s fork.

Good catch, thanks for your massive work!

artem_sylchuk → made their first commit to this issue’s fork.

Looks good for me, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

I hope that additional mesage on the module install will help to not miss the needed steps of the module configuration. The readme already contains mention of the needed steps.

artem_sylchuk → made their first commit to this issue’s fork.

Awesome, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Looks good, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Hope that will help

artem_sylchuk → made their first commit to this issue’s fork.

Awesome work, thank you guys!

Looks good, thanks!

Merged, thanks!

artem_sylchuk → made their first commit to this issue’s fork.

Thanks for checking that, marking as fixed

Awesome work! Merged, thanks!

artem_sylchuk → changed the visibility of the branch 8.x-2.x to hidden.