HTMX behavior attachment fails with some swap strategies

New test cases fail using beforestart and afterend

New tests now pass after adjusting big_pipe.js.

One question on the wait time haven't finished the review, but test only passes.

Fixed @nicxvan concern about wait time

Nightwatch tests were not visible in the "test only" job. I created a draft MR without the fix. Tests in that MR fail as expected.

Been a fly on the wall for all this HTMX stuff and very neat stuff.

Came here from the request in the maintainer slack channel.

And yes unfortunately test-only with nightwatch does not work, probably because nightwatch decides when it wants to work.

Posting the failure from the draft MR

  ️TEST FAILURE (2m 5s):  
   - 2 assertions failed; 1406 passed
   ✖ 1) htmx/htmxTest
   – Swap Before (2.382s)
   → ✖ NightwatchAssertError
   Timed out while waiting for element <.ajax-content[data-once="htmx-init"]> to be present for 1100 milliseconds. - expected "visible" but got: "not found" (1526ms)
    Error location:
    /builds/issue/drupal-3532159/core/tests/Drupal/Nightwatch/Tests/htmx/htmxTest.js:68
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
     66 |       .click('[name="replace"]')
     67 |       .waitForElementVisible(elementSelector, 1100)
     68 |       .waitForElementVisible(elementInitSelector, 1100) 
     69 |       .assert.elementPresent(scriptSelector)
     70 |       .assert.elementPresent(cssSelector);
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
   – Swap After (2.382s)
   → ✖ NightwatchAssertError
   Timed out while waiting for element <.ajax-content[data-once="htmx-init"]> to be present for 1100 milliseconds. - expected "visible" but got: "not found" (1524ms)
    Error location:
    /builds/issue/drupal-3532159/core/tests/Drupal/Nightwatch/Tests/htmx/htmxTest.js:91
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
     89 |       .click('[name="replace"]')
     90 |       .waitForElementVisible(elementSelector, 1100)
     91 |       .waitForElementVisible(elementInitSelector, 1100) 
     92 |       .assert.elementPresent(scriptSelector)
     93 |       .assert.elementPresent(cssSelector);
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––

Summary is complete
Will go on a limb since the change is small and seems to work.

nod_ → closed merge request !12492

nod_ → closed merge request !12467

Committed and pushed 7cf609309d5 to 11.x and ac36d01e3f1 to 11.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.