IconFinder does not generate url with base_url

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

In \Drupal\Core\Theme\Icon\IconFinder::processFoundFiles()

        'source' => $this->fileUrlGenerator->generateString(str_replace($this->appRoot, '', $file_absolute_path)),

does not take care of base_path

Here is a piece of code to check logic.

<?php
// Hardcode base path, i want Drupal root with subfolder, so http://domain.tld/dir is my drupal root base path.
$GLOBALS['base_path'] = '/dir/';

// Check current code, $this->appRoot does not end by /.
$appRoot = '/var/www/html';
echo(\Drupal::service('file_url_generator')->generateString(str_replace($appRoot, '', '/var/www/html/core/modules/system/tests/modules/icon_test/icons')));
// Result is : /core/modules/system/tests/modules/icon_test/icons

echo ("\n");

// Add / to the end of appRoot.
echo(\Drupal::service('file_url_generator')->generateString(str_replace("{$appRoot}/", '', '/var/www/html/core/modules/system/tests/modules/icon_test/icons')));
// Result is : /dir/core/modules/system/tests/modules/icon_test/icons

We could check first $this->appRoot does not already end by / before adding it.

Looks like tests fails for another reason but cannot launch it again.

@mogtofu33 you set "Needs work" status because of failing tests or you are waiting for another changes ?

@goz, I am still working on it to have a reliable kernel test for different base_path() values.

Current jobs fail is not related to Icon.

Left some comments on the MR.

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!