ui_icons does not generate url with base_url

Thanks for the MR, I created a follow up issue with the core Icon API for 1.1.x 🐛 IconFinder does not generate url with base_url Active .

I was too fast in merging and seems it needs more information.

The merge add a beginning slash (/) this seems to be a solution for a specific use case. Icons sources can be relative to the module with the definition (*.icons.yml) or relative to Drupal root, for example /libraries/...

There is no base_url anymore in Drupal 8+, so I guess the problem could be in your Webserver configuration to allow this sub folder.

Try to use the definition of icons relative to drupal root libraries folder ( ie: sources start with /libraries).

You should as well check on the Apache/Nginx configuration you are using and optionnaly if you have any custom specific code in your settings*.php or sites.php.

There is no base_url but base_path().

Take a look at \Drupal\Core\File\FileUrlGenerator::doGenerateString()

protected function doGenerateString(string $uri, bool $relative): string {
    // Allow the URI to be altered, e.g. to serve a file from a CDN or static
    // file server.
    $this->moduleHandler->alter('file_url', $uri);

    $scheme = StreamWrapperManager::getScheme($uri);

    if (!$scheme) {
      $baseUrl = $relative ? base_path() : $this->requestStack->getCurrentRequest()->getSchemeAndHttpHost() . base_path();
      return $this->generatePath($baseUrl, $uri);
    }
    elseif ($scheme == 'http' || $scheme == 'https' || $scheme == 'data') {
      // Check for HTTP and data URI-encoded URLs so that we don't have to
      // implement getExternalUrl() for the HTTP and data schemes.
      return $relative ? $this->transformRelative($uri) : $uri;
    }
    elseif ($wrapper = $this->streamWrapperManager->getViaUri($uri)) {
      // Attempt to return an external URL using the appropriate wrapper.
      $externalUrl = $wrapper->getExternalUrl();
      return $relative ? $this->transformRelative($externalUrl) : $externalUrl;
    }
    throw new InvalidStreamWrapperException();
  }

I don't understand why you talk about relative path to the module. In any case, in \Drupal\ui_icons_backport\IconFinder::processFoundFiles(), $this->appRoot is the root path to drupal in system, so for example : /var/www/html/web.

$file_absolute is absolute path on system, so /var/www/html/web/modules/contrib/your_module/assets/dist/img/my_image.svg for example.
If you replace $this->appRoot by empty and pass modules/contrib/your_module/assets/dist/img/my_image.svg to \Drupal\Core\File\FileUrlGenerator::doGenerateString(), this will return relative path modules/contrib/your_module/assets/dist/img/my_image.svg to the file, except in case we are using a specific base_path() other than /, url will still begin by /modules, but this path does not exists in nginx/apache config because we are waiting for different base_path.

Do you have an example where my fix broke something ?
I try differents libraries and no issues

So base_path() make more sense, mentioning base_url was confusing.

Hi,

Should it be ported on 1.1.x too?

Definitely, a d there is already a follow up on icon finder port on core

Ok, my bad, I had not checked that the change is only in ui_icons_backport, so normal that there is no commit on 1.1.x, this will happen in Core directly.

Following core API fix 🐛 IconFinder does not generate url with base_url Active , I changed a bit to strip the starting slash as it make more sense.

Automatically closed - issue fixed for 2 weeks with no activity.