fix bigpipe body removal

Sorry to be that guy, can we update the issue summary with least proposed solution? Should we have a test case that uses multiple body tags?

We already have a test with multiple body tag, that's why I added the check to the value of the hitTheFloor variable, see test-only CI run: https://git.drupalcode.org/issue/drupal-3533698/-/jobs/5753271

Thanks for keeping things in check!

Duplicate of #3161693: BigPipe corrupts HTML with multiple tags → ?

smustgrave → credited danflanagan8 → .

smustgrave → credited hammerslammer → .

smustgrave → credited wim leers → .

Does appear to be a dup to me, moving over credit.

Leaning on the test-only runner

1) Drupal\Tests\big_pipe\FunctionalJavascript\BigPipeRegressionTest::testMultipleClosingBodies_2678662
JavaScript condition met:
    (function(){
      return Object.keys(Drupal.ajax.instances).length > 0 && hitsTheFloor === "</body>";
    }())
Failed asserting that false is true.
/builds/issue/drupal-3533698/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:177
/builds/issue/drupal-3533698/core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php:63
FAILURES!

change seems to address the issue described I believe.

This is an identical fix to the one on the now duplicate issue, but there were questions about whether it was sufficient over there, so would be good to check whether those were mistaken prior to commit. If I hadn't seen that issue, I'd have thought this looks completely fine.

Does the test-only run help clear it up? https://git.drupalcode.org/issue/drupal-3533698/-/jobs/5753271

Better title :)

@smustgrave well does the test coverage here cover what was added in #3161693-13: BigPipe corrupts HTML with multiple tags → for example? This is what I'm asking.

    // But the inline script itself should not be altered.
    $this->assertSession()->responseContains(BigPipeRegressionTestController::MARKER_2678662);

I ran this locally with the change here and it did pass, without the MR it failed. Not sure if it needs to be added?

Let's add it.

added test

Committed/pushed to 11.x and cherry-picked to 11.2.x and 10.6.x, thanks!