- Issue created by @acbramley
- π¦πΊAustralia mstrelan
Had a brief look. The test waits for a menu link to be visible, then checks if a grandparent element has a class. The class
menu-item--active-trail
is added bytoolbar.menu.js
, so it's feasible that the element is visible before the class has been added. I'd probably try updating the test to use\Drupal\FunctionalJavascriptTests\JSWebAssert::waitForHelper
to test the link is visible AND the grandparent has the class. - Merge request !12692Issue #3535351: Combine class and text into wait selector β (Closed) created by acbramley
- π¦πΊAustralia acbramley
That's passed 2 runs of 100 repeats. Spinning up a clean MR to see how often it fails without the fix.
- π¦πΊAustralia acbramley
Another 100 passed with the fix, the base MR has failed 2/200
- πΊπΈUnited States smustgrave
Based on @acrambley test run, seems to have better results.
- π«π·France nod_ Lille
Can we change all the similar selectors in the method? otherwise we'd wonder why this one is using css selector and it's using named selectors above.