- Issue created by @lauriii
- Assigned to fazilitehreem
- Merge request !96#3459249: Handled context menu on right click ā (Merged) created by fazilitehreem
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 12:29pm 15 July 2024 - Assigned to jessebaker
- š«š®Finland lauriii Finland
Based on the recording looks great! š @fazilitehreem if you have a moment, it would be helpful if you could rebase this. š
Assigning for @jessebaker to review!
- š¬š§United Kingdom jessebaker
Thanks @fazilitehreem I've left a comment on the MR.
- š¬š§United Kingdom jessebaker
@fazilitehreem keep an eye on MR !93 - hopefully we will merge it soon.
- Assigned to fazilitehreem
- Status changed to Needs work
about 2 months ago 5:35am 17 July 2024 - š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
So is this issue's MR dependent on MR 93?
@Wim This ticket is dependent on MR !93 as it uses the ContextMenu, which handles right-click functionality. Therefore, this requires the changes introduced in MR !93. This also needs some work around with ContextMenu implemented.
@jessebaker I did some work around with to check how it works with the current requirements. But with the limitation of , it requires an area to trigger the context menu. On adding the area, it blocks the other MouseEvents ( grab and click ) functionality of the component.
I tried with other ways like onOpenChange or to pass the reference of the actual component but still the blocker persists. To keep the all the MouseEvents on a single components this can be handle with custom code as done earlier in !MR 36 .
Was the added on purpose to add some required feature. Can we handle it with the menu?. Need your thoughts here. thankshttps://www.loom.com/share/f5c38bbadde245f1ba22593a6070547d?sid=5274b17c...
- Issue was unassigned.
- š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
š Implement component states Fixed landed yesterday, so this is now unblocked š
- Status changed to Needs review
about 1 month ago 8:59am 30 July 2024 - Status changed to Needs work
about 1 month ago 6:07am 31 July 2024 - š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
There are unaddressed reviews on the MR from 2 weeks ago, and it's not passing tests. There's many upstream changes that need to be merged in from the past 2 weeks.
- Status changed to Needs review
about 1 month ago 4:04am 1 August 2024 - Status changed to Needs work
about 1 month ago 1:34pm 5 August 2024 - š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
Failing the
UI eslint
CI job and tests. š - First commit to issue fork.
- š®š³India omkar-pd
Solved Merge conflicts, Fixed
UI Eslint
and other tests, butCan access XB UI and do basic interactions
keeps failing. :( - š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
Ran it locally, can confirm the hard failure on:
// After hovering, the component should be outlined for both small and large viewports. cy.get('[data-xb-component-outline]')
ā¦ but that looks like a legitimate test failure: the expectations of the test need to be updated.
Notice the
// Enter the iframe to find an element in the preview iframe and hover over it. cy.getIframeBody().find('[data-component-id="experience_builder:my-hero"] h1') .first() ā¦
a few lines higher.
And so I tried this branch locally and ā¦ sure enough: it is broken. The appropriate outline only appears on click anymore, not on hover:
- Assigned to Gauravvv
- Assigned to fazilitehreem
- Issue was unassigned.
- Status changed to Needs review
25 days ago 3:58am 14 August 2024 - Status changed to Needs work
25 days ago 7:01am 14 August 2024 - š§šŖBelgium Wim Leers Ghent š§šŖšŖšŗ
I bet merging in š Account for GitlabCI intermittent path differences in SDC CSS test Fixed will fix this š¤
P.S.: you can record the screenshot/GIF I requested using https://www.cockos.com/licecap/ :)
- Status changed to Needs review
19 days ago 4:20am 20 August 2024 - š®š³India Gauravvv Delhi, India
Here is the MR screen-recording, All tests are passing now. MR is ready for review
- Status changed to Needs work
18 days ago 1:25pm 20 August 2024 - š¬š§United Kingdom jessebaker
I've reviewed - I found one small bug described on the MR and it needs some tests.
- Assigned to fazilitehreem
- Issue was unassigned.
- Assigned to Utkarsh_33
- First commit to issue fork.
The problem was related to how the position is being calculated.
By introducing isPositionUpdated and using it to control when the context menu is rendered, the new code ensures that the menu only appears after its position has been recalculated for the new location.
I'll now add some tests for this.- Assigned to jessebaker
- Status changed to Needs review
4 days ago 7:39am 4 September 2024 I think a bad merging has led to the failures of CI as it was passing here.I am assigning it to Jesse to review the changes that i have pushed along with the tests.
-
jessebaker ā
committed 5c6a55c7 on 0.x authored by
fazilitehreem ā
Issue #3459249 by jessebaker, fazilitehreem, gauravvvv, utkarsh_33,...
-
jessebaker ā
committed 5c6a55c7 on 0.x authored by
fazilitehreem ā
- Issue was unassigned.
- Status changed to Fixed
1 day ago 8:14am 6 September 2024 - šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Yay! Duplicate and move up/down and delete! š
When trying to edit, the props form is hanging but I assume that's a different problem. I know there is a performance issue that's being worked on.
- šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
I have a video that shows the behavior I'm seeing on the right sidebar props form hanging (from when I was testing the dragging behavior):
- šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Clearing the cache seems to have "fixed" the hanging props form issue (even though this was a fresh install).