- Issue created by @lauriii
- Assigned to gauravvvv
- Merge request !209Issue #3469895: Retain the space consumed by a component when it's being dragged → (Merged) created by Unnamed author
- Issue was unassigned.
- Status changed to Needs review
4 months ago 2:55am 28 August 2024 - 🇫🇮Finland lauriii Finland
This is a really nice improvement! Thank you @gauravvvv!
- Assigned to balintbrews
- Status changed to RTBC
4 months ago 9:29am 28 August 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I think this is indeed a clear improvement:
Assigning to @balintbrews for final review 😄
- First commit to issue fork.
- 🇳🇱Netherlands balintbrews Amsterdam, NL
This looks amazing! 🤩
I added a small commit to address two minor things:
- Increase contrast between ghost element and already placed elements by slightly decreasing opacity;
- Set a minimum height for the ghost element to account for newly added components where we won't have any markup rendered yet and all we have is a placeholder.
What would be nice, and I couldn't quickly find the selector for it, is to hide the name of a newly added component inside the ghost element. See on my screen capture. @gauravvvv, would you be up for taking a stab at that? If we can't easily make it happen, let's center that element inside the ghost wrapper for now, so it looks like it's intentionally there. You can do that by adding:
.sortable-ghost { /* ... */ display: flex; justify-content: center; align-items: center; }
- Status changed to Needs work
4 months ago 10:38am 28 August 2024 - Issue was unassigned.
- 🇫🇮Finland lauriii Finland
- 🇳🇱Netherlands balintbrews Amsterdam, NL
@lauriii, sure, that's why I proposed the fallback solution that makes things better immediately. 🙂 Let me push that commit quickly, then we can wrap this up.
- Status changed to Needs review
4 months ago 10:59am 28 August 2024 - Status changed to RTBC
4 months ago 11:02am 28 August 2024 - 🇫🇮Finland lauriii Finland
This looks good! We probably need couple more issues to further refine this but this is a big step forward 👍
-
Wim Leers →
committed 4de3c89b on 0.x authored by
gauravvvv →
Issue #3469895 by balintbrews, gauravvvv: Retain the space consumed by a...
-
Wim Leers →
committed 4de3c89b on 0.x authored by
gauravvvv →
- Status changed to Fixed
4 months ago 1:39pm 28 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.