- Issue created by @lauriii
- 🇬🇧United Kingdom jessebaker
In the absence of a design, here are a couple of screenshots of competing UI's that could serve as inspiration for how this might look
- 🇺🇸United States dalemoore
Very much in favor of this! It makes not only seeing the site hierarchy much easier and quicker, but you can also drag and drop the components in the view in a much more user-friendly manner. It doesn't work that way in Figma though unless you have auto-layout turned on.
Here's WordPress' implementation:
- Issue was unassigned.
- Assigned to Gauravvv
- Merge request !91Draft: #3458503: Improve the page hierarchy display → (Closed) created by Unnamed author
- 🇮🇳India Gauravvv Delhi, India
Gauravvvv → changed the visibility of the branch 3458503-Improve-page to hidden.
- Status changed to Needs review
about 2 months ago 6:23am 17 July 2024 - Issue was unassigned.
- Assigned to jessebaker
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
@lauriii I think you meant to surface this at https://contribkanban.com/board/experience_builder? 😅 Adding parent issue to make it so!
- Status changed to Postponed
about 2 months ago 9:22am 23 July 2024 - 🇫🇮Finland lauriii Finland
This is blocked on being able to test this with nested components, which would be enabled by:
- 📌 Create validation constraint for ComponentTreeStructure Needs work
- 📌 Introduce an example set of representative SDC components; transition from "component list" to "component tree" Fixed
There's also ✨ Option to change the icon for components on the page hierarchy display Active which is a soft-blocker.
- 🇺🇸United States hooroomoo
hooroomoo → changed the visibility of the branch 3458503-page-hie to hidden.
- 🇺🇸United States hooroomoo
hooroomoo → changed the visibility of the branch 3458503-page-hie to hidden.
- 🇺🇸United States hooroomoo
hooroomoo → changed the visibility of the branch 3458503-page-hie to hidden.
- 🇺🇸United States hooroomoo
hooroomoo → changed the visibility of the branch 3458503-page-hie to active.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
- Status changed to Active
25 days ago 12:49am 14 August 2024 - Assigned to hooroomoo
- 🇺🇸United States hooroomoo
hooroomoo → changed the visibility of the branch 3458503-page-hie to hidden.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
- 🇺🇸United States hooroomoo
Yeah I think you can close them. Both of them were also made before the new layers menu.
- 🇺🇸United States hooroomoo
Fixed the hover/select issue where hovering over a parent or child did not apply styling to the individual item. Next will look at fixing the Sortable functionality
- 🇺🇸United States hooroomoo
Implementation done, will try my hand at adding drag and drop tests next using cypress-real-events library....
- Status changed to Needs work
13 days ago 9:09am 26 August 2024 - Status changed to Needs review
11 days ago 9:35pm 27 August 2024 - Issue was unassigned.
- 🇫🇮Finland lauriii Finland
From design perspective, there's some improvements we still need to make – for example the layers feel a bit chunky and I'm not sure if bold is the best way to indicate slots. However, this takes the layers panel so much closer to what it should be that I'd argue that we should just ship this and work on the improvements in smaller follow-up issues 🚢
- Assigned to balintk
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Manually tested.
The screenshot in #27 is still accurate 👍
Detailed observations, none of which need to be addressed here, only in follow-ups:
- the slot names are machine names, not human-readable names
- clicking on a slot name doesn't do anything — I'd expect the entire slot to be outlined?
- the slot names are bold: why do we want to make them visually stand out compared to components? Especially due to the above point, I'd expect them to have less visual prominence.
- clicking the slot name doesn't do the same as clicking the disclosure triangle
@balintbrews is awake long before the US, so asking him to review this first 😊
- 🇺🇸United States hooroomoo
#33, #34 Yup improvements in follow-ups is good.
Just pushed low hanging fruit minor styling change so it looks less chunky and added a @todo in the tests to replace the cy.waits linking to 🐛 Unnecessary wait() use in e2e tests causing failures Active
Updated the gif in the IS to the updated one
- Assigned to bnjmnm
-
jessebaker →
committed ee1b8a9a on 0.x authored by
hooroomoo →
Issue #3458503 by hooroomoo, gauravvvv: Improve the page hierarchy...
-
jessebaker →
committed ee1b8a9a on 0.x authored by
hooroomoo →
- Issue was unassigned.
- Status changed to Fixed
4 days ago 9:50am 4 September 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
That means 📌 [PP-1] Refine dragging behavior in Layers menu Postponed is now unblocked 👍
(And I'm hopeful that #3470625-5: Dragging sections in the Layers sidebar throws error → can now be tested & closed.)
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Wow! This is great 😍 Works so well!