Unnecessary wait() use in e2e tests can cause failures and misleading fail output

Created on 27 August 2024, 3 months ago
Updated 4 September 2024, 3 months ago

Setting to critical because this is causing random fails.

Overview

Waiting for requests to complete in e2e tests is occasionally necessary when there are no reliable implementation details to wait on instead, but should only be used when absolutely necessary.

These uses can't be used as "it cant hurt to err on the side of caution and wait a little more" tools because the tests will fail if the request isn't made.

Even the wait() uses that seem more technically-sound should instead look for DOM changes etc whenever possible as endpoint requests may happen less often as our caching improves and the UI becomes more complex.

Proposed resolution

Replace andy wait() uses that can be replaced with implementation details such waiting for elements to change, etc. Any uses that can't be replaced should be accompanied by a comment explaining why (we do something similar for when !important is used in our themes and it really helps!)

User interface changes

πŸ› Bug report
Status

Active

Component

Page builder

Created by

πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024