- Issue created by @jessebaker
- Assigned to jessebaker
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
iFrame might introduce issues with the way the preview is scaled
Why can we not reproduce the same there? 🤔 I am fairly certain that is possible because of the work I did a decade ago on https://drupal.org/project/responsive_preview
- 🇬🇧United Kingdom jessebaker
It's certainly not impossible to do with an iFrame but there will be challenges around rendering the iFrame at the correct size (the same size as the content) and then scaling it smaller (you can't simply show a small iFrame because then any mobile width media queries will take effect and the preview will show the mobile styling). There may also be issues with the speed at which the content can render inside an iFrame, even if you use srcdoc).
Shadowdom might just be easier - but I'm less familiar with it so it may have unforeseen limitations too.
- Issue was unassigned.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Ahhh, gotcha! 👍 Thanks for providing that additional context 😊
- Assigned to gauravvvv
- Assigned to utkarsh_33
- Merge request !158Issue #3466303: Component previews in left menu don't have style encapsulation → (Merged) created by Unnamed author
- Assigned to gauravvvv
- Status changed to Needs work
5 months ago 4:06am 9 August 2024 - 🇮🇳India gauravvvv Delhi, India
Tests are failing, working on them.
Here is the after MR screen recording:
- Issue was unassigned.
- Status changed to Needs review
5 months ago 8:06am 9 August 2024 I have fixed the tests.It's up for a review.As i was also working on the same issue so i thought i could fix the tests.
- Assigned to utkarsh_33
- Status changed to Needs work
5 months ago 9:02am 9 August 2024 - Status changed to Needs review
5 months ago 9:22am 9 August 2024 - Assigned to jessebaker
-
jessebaker →
committed abdf28ad on 0.x authored by
Gauravvvv →
Issue #3466303 by Utkarsh_33, Gauravvvv: Follow-up for #3462636:...
-
jessebaker →
committed abdf28ad on 0.x authored by
Gauravvvv →
- Issue was unassigned.
- Status changed to Fixed
5 months ago 11:23am 9 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.