- Issue created by @bnjmnm
- 🇺🇸United States bnjmnm Ann Arbor, MI
Are tests feasible for this? 🤔
Yes -
- create a test-only component that uses VH units for its height
- In an e2e test first drag the component into the layout
- Check the iframe height and confirm it isn't absurdly large due to it determining height based on a seemingly infinitely tall vh-height component
- Assigned to gauravvvv
- Merge request !138Draft: Issue #3463610: VH units fix only works for inline styles → (Open) created by Unnamed author
- Issue was unassigned.
- Status changed to Needs work
8 months ago 3:28am 2 August 2024 - Assigned to bnjmnm
- 🇬🇧United Kingdom jessebaker
Came across this pretty old one!
In some very quick testing this still seems to be slightly problematic. I made a code component with a 50vh height. While it doesn't seem to grow infinitely in size, the 50vh IS based on the height of the iFrame and on a very long page that can be huge.
Perhaps a different solution would be to get the height of the parent window and base the vh calculation on that rather than the height of the iFrame/whole page. It's still not perfect, but at least it will more likely be closer to the intended height.