- Issue created by @Zsuffa Dรกvid
- Status changed to Needs review
over 1 year ago 2:29pm 1 February 2023 - ๐ญ๐บHungary Zsuffa Dรกvid
I attached a possible patch to resolve the issue.
- ๐ฎ๐ณIndia Nayana Ramakrishnan
Verified the patch #3 and tested it on Drupal version 10.1.x. The patch works fine and I have added the before and after screenshots for reference.
- ๐ฎ๐ณIndia sonam.chaturvedi Pune
Verified and tested patch #3 on 10.1.x-dev. Patch applied successfully.
Test Steps:
1. Goto /admin/content/media-grid
2. Add media with short filename
3. Verify media-grid the item's name is higher than the space under the item preview
4. Apply patch #3
5. Verify media-grid the item's name is within the spaceTest Result: media-grid the item's name is within the space under the item preview
Screenshot is same as #4RTBC +1
- Status changed to RTBC
over 1 year ago 11:54am 2 February 2023 - Status changed to Needs work
over 1 year ago 1:08pm 2 February 2023 - ๐ซ๐ฎFinland lauriii Finland
Based on https://www.figma.com/file/VNkUIvfbcGr9Jmez3iRXJBjb/Media-widget-field?n..., it looks like there shouldn't be spacing between the name and the image preview. After this change, there would be some spacing:
- ๐ญ๐บHungary Zsuffa Dรกvid
In the figma design the media items don't contain any images.
But based on your screenshot I made a new patch addressing the space issue.
- Status changed to Needs review
over 1 year ago 8:42am 7 February 2023 - ๐ฎ๐ณIndia Gauravvv Delhi, India
Fixed
order/properties-order
. Attached patch and interdiff for same. please review - ๐ฎ๐ณIndia Nayana Ramakrishnan
Verified the patch #10 and tested it on Drupal version 10.1.x. Patch applied cleanly but for image with small height, there is still space between the name and the image preview. I have added the before and after screenshots for reference.
- Status changed to Needs work
over 1 year ago 4:56pm 18 February 2023 - ๐บ๐ธUnited States smustgrave
Since this is a UI change screenshots should be added to the issue summary please.
- Status changed to Needs review
over 1 year ago 2:50pm 21 February 2023 - Status changed to Needs work
over 1 year ago 3:42pm 21 February 2023 - ๐บ๐ธUnited States smustgrave
Issue summary proposed solution is to shrink item__attributes but I see we are editing the image. Proposed solution needs to match the patch solution.
Also seems to have caused a regression when you select an item in the media library widget a weird grey line appears on the side.
- Assigned to akashdab