Contrib.social

Create a gap or control the space between the Label and input field in the quick-edit toolbar for image field.

Open on Drupal.org →
Created on 10 May 2021, over 4 years ago
Updated 11 July 2023, over 2 years ago

Problem/Motivation

Olivero: Label and input field in the quick-edit toolbar does not have a space between them which makes them odd and the focus of the input field overlaps with the label.

Steps to reproduce

1. Go to any node.
2. Quick edit the node, the content type of the specific node page must contain an image field.
3. Hover the mouse on the image.
4. You will see the quick-edit toolbar with the label name alternative text and input field.
5. There is no space between the label and the input field, the focus of the input field overlaps the label.

Please refer the video attached for reference.

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Olivero  →

Last updated about 2 months ago

Created by

🇮🇳India tushar_sachdeva

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 2 years ago →
    🇮🇳India vinaymahale

    Any updates over here?

  • Status changed to Needs review over 2 years ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update over 2 years ago
    Patch Failed to Apply
  • Comment over 2 years ago →
    🇮🇳India Harish1688 India

    Hi,

    The recent patches #20 and #22 have failed, so we need to re-roll the patch based on core 10 and 11. The following points should be considered:
    1. As mentioned in #5, since Quick Edit will be deprecated, any changes should be made in their respective stylesheets.
    2. Both LTR and RTL cases have been tested and are functioning correctly.

  • Status changed to Needs work over 2 years ago
  • Comment over 2 years ago →
    🇺🇸United States smustgrave

    Please include interdiffs with your patches.

  • Status changed to Needs review over 2 years ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update over 2 years ago
    Custom Commands Failed
  • Comment over 2 years ago →
    🇮🇳India Harish1688 India

    Hi @smustgrave ,

    I apologies for the previous patch failure in #27. I forget to include the files in the patch and also to add the interdiff.
    I will now upload the new patch (3213158-29.patch) along with the interdiff.

  • Status changed to Needs work over 2 years ago
  • Comment over 2 years ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024