Olivero: Fix long menu (desktop) design

Working on this will provide the patch to the following issue.

Attaching the patch

Working on the tests

Adding Updated patch

Work in progress

I have fixed the build errors, also added the interdiff for same. please review

Since custom commands are failing I am working on the fix will provide the updated patch

Adding the patch and the interdiff file.

Kindly review the issue

@Hamid.ali please don't assign tickets to yourself unless a maintainer per the policy.

Tagging for subsystem maintainer to see if this is actually a bug.

Removing credit for @arti_parmar for the empty MR.

@arti_parmar FULL TRANSPARENCY: I have already commented on another issue about this same behavior..

I see you have opened a merge request that is empty. Perhaps you do not know the process?
Here is a link to some documentation on Drupal.org: Creating merge requests →

When you open a merge request or post a file it ticks the credit box for attribution and creates more work for maintainers when they close the issues. Please refrain from opening a merge request unless you are working on code.

@smustgrave has already unticked the attribution box, as you did not contribute to the conversation, let me know if you have any questions.

~AmyJune, Core Mentor and CWG Community Health team member

@Hamid.ali Here is a link to issue queue etiquette: href=" https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → ">Issue Queue Etiquette
# 9 in the Donts section

Don't: Assign yourself issues in the Drupal Core issue queue. That is saved for maintainers of the project. Please note, you can use a comment to inform others that you are working on an issue.

~AmyJune, Core Mentor and CWG Community Health team member

I tried to reproduce and fix the above-addressed issue with the help of patch #11 on Drupal-10.1.x-dev. The patch was applied successfully without throwing any error and fixed the raised issue. The updated changes match the figma design as well. I am attaching a screenshot for reference, showing the state before and after applying the patch.

Hello, applied patch #3 and it is working a expected. Here are the before and after screenshots for desktop and mobile. RTBC++.

Moving this to RTBC based on #19 and #20.
Thanks

I'm triaging RTBC issues → .

This issue does not have an issue summary! There is no explanation of the problem or what the fix is supposed to do. The title is often a clue but in the case it does not help me know what the problem is. The issue summary should contain the important information that committers and reviewers need to assess a change. Since that is missing, I am setting to 'Needs work' for an issue summary update and tagging. I am also restoring the standard template that should be used for all core issues. It is how we keep track of the work completed and the work still to do.

There is lots of information in the Drupal wiki that explains how we work. In particular, there is information for how to Write an issue summary for an existing issue → . There is also more information at Issue summaries matter → .

@snehal-chibde, testing of a patch should be done on the latest version. If not, then you should explain why testing was done on an old version.

This issue has patches and an MR. It will help if the issue summary clarifies which one is the reviewed.

Based on the comment #22, added the issue summary.
Also Tested the patch 3370683-11.patch with latest 11.x. But found a issue in that, after applying the patch search icon not showing. attached a image for reference.

Testing with version 11.x

Hi @Harish1688,
It is visible for screens above 1024px and for the below screens it follows the mobile design in which the search block is placed inside the hamburger panel.

Tested #11 patch with Drupal 11.x working fine the search block is designed as per the requirement mentioned in the IS but still, some issues exist -

- Focus ring is misaligned on the search icon.

- Alignment of the search icon and the menu does not look correct below 1200px screen.