[Entity browser]: Hover state in entities list looks odd

Created on 29 May 2022, over 2 years ago
Updated 25 January 2023, almost 2 years ago

Problem/Motivation

If you hover a field item in the entities list of the selection it get highlighted with border color. This looks very odd to me. The hover status is also indicating some action related to the field item imho, while there is no action on this field item. The actions of the selection are related to the edit/remove button and dragging the whole selection item. This does not correspond to this hover style.
Screenshot:

Steps to reproduce

Use entity browser with "Rendered entity" display for the selection having some fields configured in the entity display. Then hover over a field in the selection.

Proposed resolution

Just remove the hover style.

Remaining tasks

create a patch

User interface changes

Remove hover style on selection item fields

API changes

na

Data model changes

na

🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇩🇪Germany stefan.korn Jossgrund

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India nayana_mvr

    Verified the patch #5 and tested it on Drupal version 10.1.x and Gin theme version 8.x-3.x. The hovering state is removed now but I think the alignment of the field items in the entities list of the selection need to be adjusted. Some text are even cropped in the left side. Please find the screenshots for reference.

  • 🇮🇳India lokeshsahu Delhi

    As per the previous comment #6, I have created another patch to address the alignment of the field items in the entities list issue. I am attaching a screenshot showing the state before and after applying the patch.

  • 🇮🇳India lokeshsahu Delhi

    As per the previous comment #6, I have created another patch to address the alignment of the field items in the entities list issue. I am attaching a screenshot showing the state before and after applying the patch.

  • Assigned to Harish1688
  • 🇮🇳India Harish1688 India

    working on this ...

  • Issue was unassigned.
  • 🇮🇳India Harish1688 India

    Hi,

    Tested the patch 3283018-7.patch, points covered in the patch.

    1. The issue with the hover state on the field has been successfully resolved.
    2. The issue regarding the alignment of field items in the entities list of the selection is also addressed in point #6.

    screenshot attached.

    Looks Good for RTBC

  • 🇦🇺Australia acbramley

    +1 to RTBCing this, it makes a massive difference for non rendered entities too (i.e labels or a custom display widget plugin) mainly due to the removal of the word break.

    Before:

    After:

  • First commit to issue fork.
  • Merge request !547Add 3283018-7.patch → (Open) created by dieterholvoet
  • 🇧🇪Belgium dieterholvoet Brussels

    i rebased 3283018-7.patch onto 8.x-3.x and started a MR.

  • Pipeline finished with Success
    11 days ago
    Total: 214s
    #365508
Production build 0.71.5 2024