Hover not working when changing from vertical to horizontal

Created on 10 November 2022, about 2 years ago
Updated 28 February 2024, 10 months ago

Problem/Motivation

Hover not working as expected after switching from vertical to horizontal.

Steps to reproduce

Using the Seven theme for the Admin Theme, when the admin toolbar is horizontal, the hover dropdown menus work as expected. When I change the admin toolbar to vertical, then click on a menu item, the menu item loads the page as expected. Then when I change back to horizontal toolbar, the hover dropdown items do not work until I reload the page. I have tested with aggregation on and off (both css/js), but the problem persists either way.

🐛 Bug report
Status

Needs review

Version

3.4

Component

User interface

Created by

🇺🇸United States thalemn

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India Harish1688 India

    Hi,
    Tried to replicate the issue on local with same Drupal 9.4.8 with admin toolbar 3.2.1. and testing the things steps wise as provided but not facing any issue on hover state when switch to vertical to horizontal toolbar mode. Hover working fine and by access by tabs focus also working fine.

    can you please provide more info or (UI) to issue, so would be able to generate.

  • 🇮🇳India nagsept3

    Yes. Tested at local. not able to reproduce the error

  • 🇮🇳India Harish1688 India

    Hi @thalemn,

    Tried with same info as you provided to reproduced the issue on local. but not able to reproduce the issue on local, it's working fine.
    attached a GIf for reference.

  • 🇺🇸United States thalemn

    @Harish1688

    Thanks for providing the gif.

    There appears to be a step missing in your gif demo: when you switch from horizontal to vertical, click on an admin link to open the page (for example, click on Block layout link to open the Block layout page (/admin/structure/block). After that page opens (with the admin toolbar in the vertical position), switch the toolbar back to horizontal. Then the horizontal links do not hover for me.

    Can you please try again?

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • 🇮🇳India swatidhurandhar

    Hi, I was able to reproduce the issue with above steps. Please find the attached patch for the fixes.
    Thanks

  • 🇧🇹Bhutan Pema Namgyel

    Thanks buddy for the patch. I have reviewed the patch and its fixing the issue. Attaching the video for the same.

  • 🇺🇸United States thalemn

    Thank you. I have applied the patch in #9 and the hover issue has been fixed.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • 🇮🇳India swatidhurandhar

    Just updated the patch from #9.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 11 months ago
    Waiting for branch to pass
  • 🇮🇳India keshavv India

    I can reproduce the issue.

    Set the menubar vertical.
    Reload the page.
    Change the menubar position to horizontal and try to hover on the menu without reloading the screen.
    Hover will not work.

    However, The given patch failed to apply to me on version 3.4 so I have created a new for it.
    Please review.
    Thank you.

  • 🇮🇳India Sandeep_k New Delhi

    @keshavv, Tested the shared Patch 3320479-14.patch on Drupal version- 9.5.11. The patch was applied successfully and looks good to me.
    Testing Steps:

    1. Drupal 9.5> Add the Admin Toolbar module.
    2. Switch to the vertical toolbar.
    3. Click on the link in the vertical toolbar (any module link for example).
    4. Switch back to the horizontal toolbar.
    5. Hover over horizontal toolbar links to reproduce this issue.
    6. Download the shared patch and Apply.
    7. Reverify this issue by following the above steps.

    Testing Results:
    After applying the patch, the hover is working fine while we switch back to the horizontal toolbar from the vertical toolbar. RTBC++

  • 🇮🇳India Kanchan Bhogade

    Hi,
    I've tested the Patch 3320479-14.patch on Drupal version- 9.5.12.
    The patch was applied successfully...

    Followed the same steps as mentioned in #15

    Testing Results:
    The hover functionality is working fine when the user switches back to the horizontal toolbar from the vertical toolbar.
    RTBC++

    attaching videos

    Keeping in "needs review" for code verification

Production build 0.71.5 2024