- Issue created by @shweta__sharma
- Merge request !297gin-3384466:Fixed apply to selected button alignment issue. → (Open) created by shweta__sharma
- Status changed to Needs review
about 1 year ago 7:13am 31 August 2023 I have pushed the code for the same, also attached a screenshot for reference. Please review.
Thanks- Status changed to RTBC
about 1 year ago 8:53am 31 August 2023 - 🇮🇳India swatidhurandhar
I verified the MR request and it fixes the issue.
Moving it to RTBC. - Status changed to Needs work
about 1 year ago 6:54am 8 September 2023 - 🇮🇳India shubham_jain
Hi @saschaeggi, the previous css commited in the comment #2 didn't worked in my machine. See the attached screenshot.
So, I updated the css which fixed the issue and it is generic.Please review and verify.
- @shubham_jain opened merge request.
- Status changed to Needs review
about 1 year ago 12:52pm 8 September 2023 - Status changed to Needs work
about 1 year ago 10:57am 17 September 2023 - 🇨🇭Switzerland saschaeggi Zurich
I've provided code feedback. Please have a look and update the MR.
- Status changed to Needs review
about 1 year ago 3:56pm 17 September 2023 Hi,
Based on the comment #13, need to verified the code feedback. In comment #15 code feedback is done. remove the duplicate code from the
_views.scss
file. Also tested the misaligned issue in MR, Button and input field are top align and vertical centre, if it's fine then issue is resolved. attached the images for reference.Removed Duplicate code.
.form-actions { margin-top: 0; }
Before MR:-
After MR:-
Hi @Harish1688,
We need to align this vertically too, I have created a patch pls try this and let me know if it is working fine.
For me, it's working fine, attached a screenshot for reference.
ThanksHi shweta__sharma,
In the ticket a
Merge request !297
already open and all the last changes are done in this MR. So (Patch is not required here) please push your changes in MR for review.- 🇮🇳India Kanchan Bhogade
Hi,
I verified and tested the 3384466-17 patch on the Drupal 10. 2 version.Testing steps:
- Install Drupal version 10. 2
- Install the theme
- Use the gin theme as an Administration theme
- Go to /admin/structure/views/view/content
- Check the bulk-actions block at the bottom
- See the Apply to selected items button alignment
- Apply the Patch and check the alignment of the Button
Test Result:
The Verticle alignment also looks good
Attaching screenshots for referenceKeeping status Need reviews for code review
- Assigned to iro
- 🇬🇷Greece iro
There are unresolved threads at the MR so I am reverting this issue to needs work.
Hi shweta__sharma,
I have fixed this issues kindly find attached patched and review. Also check fixed version screen shot.
Thanks
Hi Team,
I wanted to share the steps I followed during the creating MR process:
1. Installed Drupal version 10.2 and Drupal 11.
2. Installed the theme.
3. Set the Gin theme as the administration theme.
4. Navigated to /admin/structure/views/view/content.
5. Checked the bulk-actions block at the bottom of the page.
6. Observed the alignment of the Apply to selected items button.
7. Fixed the CSS issue in the file dist/css/base/gin.css.
8. Created the merge request (MR) and fixed the issue.Result: The vertical alignment of the button looks good. I have attached before and after screenshots for your reference.
- 🇮🇳India deepak tomar
I have tested the patch #23( https://www.drupal.org/files/issues/2024-10-03/button-misaligned-3384466... → ), and it is working fine for me. Attaching the screenshot for reference.