- Issue created by @gauravvvv
- last update
over 1 year ago 30,063 pass - @gauravvvv opened merge request.
- Status changed to Needs review
over 1 year ago 2:52am 30 August 2023 - 🇮🇳India snehal-chibde
hello, This is not replicated on Drupal 11 Claro theme.
Can you please provide any more details how this gets replicated? - Status changed to Needs work
over 1 year ago 9:52am 30 August 2023 - 🇮🇳India yash.rode pune
Hi @Gauravvvv, can you please provide steps to reproduce so that someone can confirm this and get it fixed.
- Status changed to Needs review
over 1 year ago 12:16pm 30 August 2023 - 🇮🇳India gauravvvv Delhi, India
I added the issue summary earlier, somehow it got removed. I have added it again.
- 🇮🇳India yash.rode pune
I followed steps to reproduce with Claro theme, the throbber is spaced right for me.
- 🇮🇳India gauravvvv Delhi, India
So the spacing with action-link button is 24px, but it should be 12px as with other buttons.
With other buttons, if we have margin-right, then we don't have margin-left on the ajax progress icon. But in case of action-link, we do have margin-right on the button and we have margin-left on the ajax progress icon also. So the margin left 12px is extra spacing here.I have added few screenshots for better understanding.
- 🇺🇸United States smustgrave
Also followed the steps and not seeing the issue.
- 🇮🇳India gauravvvv Delhi, India
I have added a screen recording as well.
In the first button, "Add Media" we have margin-right to the button and we don't have any margin-left on the ajax-progress-icon.In the second button, "Delete" we have margin-right on the delete button additionally we have margin-left on the ajax-progress icon. That extra margin-left is the issue.
Hope it is clear now.
- 🇮🇳India Harish1688 India
Hi,
As pr comment #10, Tested the MR !4670 for the issue spacing inconsistency in AJAX progress icon with action button
(spacing between button and loader right side)
. found the issue on local and tested the solution given in MR, it's resolved the issue. images attached for references.Testing Ste
1. Drupal 11.x setup and go to content page admin/content, Claro set as backend theme
2. Edit node type (Article), click on the delete button, and media button found the issue ( it's 24px, but it should be 12px).
3. Moved the MR and verified the solution, it's working fine.Media loader spacing
Delete loader spacing Before
Delete loader spacing After patch
Looks good for RTBC+
- Status changed to RTBC
about 1 year ago 7:35pm 18 September 2023 - 🇺🇸United States smustgrave
Per testing in #11 going to see what committers think.
- last update
about 1 year ago 30,164 pass - last update
about 1 year ago 30,168 pass - last update
about 1 year ago 30,205 pass - last update
about 1 year ago 30,205 pass - last update
about 1 year ago 30,360 pass 5:28 1:15 Running- last update
about 1 year ago 30,360 pass - last update
about 1 year ago 30,371 pass - last update
about 1 year ago 30,379 pass - last update
about 1 year ago 30,377 pass - last update
about 1 year ago 30,382 pass - last update
about 1 year ago 30,392 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,414 pass - last update
about 1 year ago 30,417 pass - First commit to issue fork.
- last update
about 1 year ago 30,420 pass - Status changed to Fixed
about 1 year ago 3:15am 20 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.