- Status changed to Needs review
over 1 year ago 8:03am 29 June 2023 - last update
over 1 year ago 29,563 pass - 🇮🇳India gauravvvv Delhi, India
Updated logical properties in #29, attached interdiff for same. please review
- 🇮🇳India Harish1688 India
Hi,
After applying the patch 3294006-33.patch, the following points were observed:1. CSS Logical Properties and nesting are utilized appropriately. (mostly all classes have variables, so found few changes on css Properties - like margin and text-indent)
2. The UI and focus states remain unchanged, showing no difference in behavior compared to the previous version.Screenshot attached
looks good to RTBC
- Status changed to RTBC
over 1 year ago 1:21pm 29 June 2023 - last update
over 1 year ago 29,571 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,807 pass - last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,822 pass - last update
over 1 year ago 29,842 pass - Status changed to Needs review
over 1 year ago 6:06pm 23 July 2023 - 🇫🇮Finland lauriii Finland
+++ b/core/themes/claro/css/components/form--text.pcss.css @@ -50,7 +50,7 @@ + text-indent: calc(0.75rem - 0.0625rem); /* Text-input fallback for non-supporting browsers like Safari */
Why is this not using the variable anymore?
- last update
over 1 year ago 29,878 pass - 🇮🇳India gauravvvv Delhi, India
Updated the variable, added the interdiff for same
- Status changed to RTBC
over 1 year ago 5:11pm 24 July 2023 - last update
over 1 year ago 29,881 pass - last update
over 1 year ago 29,885 pass - last update
over 1 year ago 29,908 pass - last update
over 1 year ago 29,910 pass, 2 fail The last submitted patch, 37: 3294006-37.patch, failed testing. View results →
- last update
over 1 year ago 29,946 pass - last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,941 pass, 2 fail The last submitted patch, 37: 3294006-37.patch, failed testing. View results →
- last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,959 pass - Status changed to Fixed
over 1 year ago 8:54am 16 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.