Fix PHPSTAN validation errors

------ ------------------------------------------------------------------------------------------------------------------------------------------ Line src/Plugin/Field/FieldFormatter/ImageLinkFormatterTrait.php (in context of class Drupal\image_link_formatter\Plugin\Field\FieldFormatter\ImageLinkFormatter) ------ ------------------------------------------------------------------------------------------------------------------------------------------ 92 Parameter #1 $items (Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface>) of method Drupal\image_link_formatter\Plugin\Field\FieldFormatter\ImageLinkFormatter::viewElements() should be compatible with parameter $items (Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>) of method Drupal\Core\Field\FormatterInterface<Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>>::viewElements() 🪪 method.childParameterType 92 Parameter #1 $items (Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface>) of method Drupal\image_link_formatter\Plugin\Field\FieldFormatter\ImageLinkFormatter::viewElements() should be compatible with parameter $items (Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>) of method Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::viewElements() 🪪 method.childParameterType 94 Parameter #1 $items of method Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::viewElements() expects Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>, Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface> given. 🪪 argument.type ------ ------------------------------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------------------------------ Line src/Plugin/Field/FieldFormatter/ImageLinkFormatterTrait.php (in context of class Drupal\responsive_image_link_formatter\Plugin\Field\FieldFormatter\ResponsiveImageLinkFormatter) ------ ------------------------------------------------------------------------------------------------------------------------------------------ 92 Parameter #1 $items (Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface>) of method Drupal\responsive_image_link_formatter\Plugin\Field\FieldFormatter\ResponsiveImageLinkFormatter::viewElements() should be compatible with parameter $items (Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>) of method Drupal\Core\Field\FormatterInterface<Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>>::viewElements() 🪪 method.childParameterType 92 Parameter #1 $items (Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface>) of method Drupal\responsive_image_link_formatter\Plugin\Field\FieldFormatter\ResponsiveImageLinkFormatter::viewElements() should be compatible with parameter $items (Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>) of method Drupal\responsive_image\Plugin\Field\FieldFormatter\ResponsiveImageFormatter::viewElements() 🪪 method.childParameterType 94 Parameter #1 $items of method Drupal\responsive_image\Plugin\Field\FieldFormatter\ResponsiveImageFormatter::viewElements() expects Drupal\Core\Field\EntityReferenceFieldItemList<Drupal\Core\Entity\EntityInterface>, Drupal\Core\Field\FieldItemListInterface<Drupal\Core\Field\FieldItemInterface> given. 🪪 argument.type ------ ------------------------------------------------------------------------------------------------------------------------------------------ [ERROR] Found 6 errors

Comments & Activities

Issue created by @dydave
Comment 24 days ago →
🇫🇷France dydave
Pipeline finished with Success
24 days ago
Total: 311s
#551661
Merge request !9Issue #3536938 by dydave: Fixed PHPSTAN validation errors by inheriting doc... → (Merged) created by dydave

Comment 24 days ago →

System Message

dydave → committed a661169f on 2.2.x

Issue #3536938 by dydave: Fixed PHPSTAN validation errors by inheriting...

Comment 24 days ago →
🇫🇷France dydave
Removed the doc comment block of method:
Drupal\image_link_formatter\Plugin\Field\FieldFormatter\ImageLinkFormatter::viewElements
and replaced with an {@inheritDoc} block to directly inherit from its parent:
Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::viewElements

Fewer overridden doc comment blocks means less code and less maintenance for us.

The changes were merged above at #4 and the dev pipelines are back to passing 🟢 \o/
https://git.drupalcode.org/project/image_link_formatter/-/pipelines/551669

Marking issue as Fixed for now.

Thanks!
Comment 10 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix PHPSTAN validation errors

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9Fix PHPSTAN validation errors
Merged

Comments & Activities

Fix PHPSTAN validation errors

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9Fix PHPSTAN validation errorsMerged

Comments & Activities

!9Fix PHPSTAN validation errors
Merged