- Merge request !3248Issue #2803061 by BR0kEN, xavier.masson, vsujeetkumar, bhanu951: Cleanup of... → (Open) created by bhanu951
- Status changed to Needs work
almost 2 years ago 3:48pm 13 February 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
This could use test coverage
- 🇻🇳Vietnam linhnm
Rerolled patch from #36 against 9.5.4. No other changes.
- last update
over 1 year ago 30,215 pass, 109 fail - last update
6 months ago 29,689 pass - 🇸🇪Sweden meanderix
Here's another consequence of this bug. We discovered that we have 16000+ old batch jobs left in the queue table.
_drush_batch_worker()
invokesDrupal\Core\Queue\DataBaseQueue::claimItem()
, which generates a query similar to this:SELECT * FROM queue q WHERE name='drupal_batch:123301:0' ORDER BY item_id ASC LIMIT 0, 1;
This query now takes about 6 seconds to execute!
Now, during an upgrade, drush commands such as `locale:check` and `locale:upgrade` takes forever to execute because of this (they repeatedly add new batch jobs). Even enabling a new module will have this effect, since it will invoke the locale module to look for translations.
- Status changed to Needs review
24 days ago 2:11pm 28 November 2024 - 🇺🇸United States smustgrave
MR and patch seem very different, was some stuff missed?
- 🇮🇳India bhanu951
@smustgrave issue is rescoped check #40, patch rerolls are not correct. MR 3248 is relevant.
- 🇺🇸United States smustgrave
Then the needs tests tag still seems relevant hear so moving back to NW thanks