Here's another consequence of this bug. We discovered that we have 16000+ old batch jobs left in the queue table. _drush_batch_worker() invokes Drupal\Core\Queue\DataBaseQueue::claimItem(), which generates a query similar to this:
SELECT * FROM queue q WHERE name='drupal_batch:123301:0' ORDER BY item_id ASC LIMIT 0, 1;
This query now takes about 6 seconds to execute!
Now, during an upgrade, drush commands such as `locale:check` and `locale:upgrade` takes forever to execute because of this (they repeatedly add new batch jobs). Even enabling a new module will have this effect, since it will invoke the locale module to look for translations.
Even with the patch, we will have a problem when utilizing EntityRepository::getCanonicalMultiple(), which will discard the provided $contexts array and use a separate $legacy_context variable when calling getTranslationFromContext(). How can we make strict_fallback apply for this method as well? (This has implications when using e.g. EntityBase::access() which will return true even though the translation does not exist.)
@Murz The MR seems to be missing the necessary changes in #22 (i.e. correctly handle the case where only one language exists)?
Here is my proposed patch, which is much more in line with how other modules handle this. See e.g. Drupal\ckeditor5\Plugin\CKEditor5PluginConfigurableTrait and Drupal\workflows\Plugin\WorkflowTypeBase.
meanderix → created an issue.
meanderix → created an issue.
This patch is no longer compatible with version 1.4. Should this be merged into the module?
meanderix → created an issue.
meanderix → created an issue.
Does this also fix 🐛 jQuery UI dialog modals repositions incorrectly on window resize when there is a off canvas rendered Needs review ?
meanderix → created an issue.
This patch is failing after changes made in #3350972 (Drupal 9.5.9). Are these two patches fixing the same thing?
Here's the patch that I think went into core:
https://www.drupal.org/files/issues/2023-04-10/3350972-9.4_9.5-16.patch →
Patch updated. We can not get the uid from a presave-hook (when the account is first created), but it should work in an update-hook.
Minor adjustment. Remove user_access route from tac_lite.links.task.yml.
Updated for version 1.6.
meanderix → created an issue. See original summary → .