[random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections()

Not sure yet why exactly but it seems to be a timing issue, attached patch should fix it.

The patch showing that LayoutBuilderUiTest has random fails is here: #2856047-65: Avoid random failures in JavascriptTestBase when testing functionality in a dialog → .

No idea how this works, but core-3350972-2.patch shows that it _does_ work.

RTBC for me, core-3350972-2-full-suite.patch is the patch to commit.

I got some helpful context from @nod_ on Slack:

executing at the start of the debounce prevents the use of settimeout (for the first call anyway) so a line like $(window).on('myevent', debounce(func, 100, true)).trigger('myevent') will be added to the execution stack and executed in the order it's called. When the callback is executed in the settimeout that messes with the order of execution and I think that's what is causing issues in testing

I don't think it's only in testing, I don't use offcanvas often so I didn't run into it yet but it makes sense that it would happen from time to time for

It sound like this a bug that at least @larowlan had hit. @nod_ explained that this is expected behavior for Drupal.debounce, and that the problem is about the usage of it.

Committed 8ea9e1c and pushed to 10.1.x. Also backported to 10.0.x. Thanks!

I also backported this to 9.5.x and 9.4.x since it interferes with the security advisory development process.

Whoopsidaisy, JS needs to be rebuilt for the D9 backports. Fail was: https://www.drupal.org/pift-ci-job/2639435 →

This is actually critical; updating metadata.

Also given the above criticality, I committed the backport straight from NR. Thanks @Spokje!

Automatically closed - issue fixed for 2 weeks with no activity.

Does this also fix 🐛 jQuery UI dialog modals repositions incorrectly on window resize when there is a off canvas rendered Needs review ?

I think this may have caused a bug with browser resizing. See https://www.drupal.org/project/drupal/issues/3359465 🐛 Layout builder off-canvas positioning problem when resizing browser Needs work