Error: Call to a member function revokePermission() on null

It works for me.

The fix looks good, thanks. Let's just add a test when using the user_role_revoke_permissions() with non-existing rid.

I came across this issue the other day and found this patch, worked for my situation.

Added the test to check that this patch fixes the issue.

The last submitted patch, 5: 3365626-5_failed_test.patch, failed testing. View results →

I think the failure is caused because of the patches order (which does matter here). The regular patch needs to be the last one to pass.

Anyway, I think the patch looks good, it has tests and the fix is the same as in user_role_grant_permissions(). Thanks!

Hiding patches so hopefully when it retests it won't auto fail it.

Triggering a 11.x build.

Passed 11.x

And test-only patch of #5 shows the issue.

The last submitted patch, 5: 3365626-5.patch, failed testing. View results →

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)