GitlabCI: Fix ESLINT validation errors

Quick follow-up on this issue:

A few additional commits were added to the current merge request MR!75 with a few comments, see above at #2.

But mostly, at this point:
Last build on MR!75: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/pipelines/181273

• The ESLINT job now seems to be passing ✅
  ESLINT job: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/1679160
   
• The PHPUnit Tests are passing as well 🟢 \o/
  PHPUnit job: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/1679162

Added temporary commit to be reverted:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/75/dif...
ported from 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC , based on MR MR!68 to pass phpunit tests and add .gitlab-ci.yml file.
Revert this commit once these changes are merged in the development branch.
 

We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!75 and let us know if there would be any more work needed.

Feel free to let us know if you have any questions or concerns on merge request MR!75 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews.

Changes looks good, CI passing, can we get it merged? this will unblock the Drupal 11 compatibility issue - 📌 Add Drupal 11 support Needs review .
Thanks!

Rebased MR!75 on 3.x with gitlabci tests and required eslint job to pass.

✅ Merge request seems to complete successfully with all ESLint validation errors fixed, see:

• MR: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/pipelines/241728
• ESLint: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/2315350

Back to Needs review for more reviews, testing and feedback.
Thanks!

Because our tests don't have great coverage, I'd want to ensure this is manually tested a bit before committing. I've had issues where seemingly innocent js linting changes actually broke modules before.

We're not going to be able to get this fixed in one go....
There are too many changes and moving parts...

We should probably consider breaking this down into smaller tickets, maybe something like

• GitlabCI: Fix ESLINT validation errors in admin_toolbar
• GitlabCI: Fix ESLINT validation errors in admin_toolbar_search

 
Therefore, we should create a new merge request with only the following files:

admin_toolbar_search/admin_toolbar_search.services.yml
admin_toolbar_tools/admin_toolbar_tools.services.yml
js/admin_toolbar.hover.js
js/admin_toolbar.hoverintent.js
js/admin_toolbar.js
.eslintignore

and address the remaining files from the initial MR!75 in a separate ticket:

admin_toolbar_search/js/admin_toolbar_search.js
.gitlab-ci.yml

Updated issue title and remaining tasks in the IS.

dydave → changed the visibility of the branch 3449577-gitlabci-fix-eslint to hidden.

Re-rolled previous merge request for the latest version of the module, fixed all conflicts and created a new merge request:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/116

ESLINT job is passing green 🟢
Build: https://git.drupalcode.org/project/admin_toolbar/-/pipelines/431041
Job: https://git.drupalcode.org/project/admin_toolbar/-/jobs/4439405

Additionally, all PHPUnit tests and in particular FunctionalJavascript are all passing 🟢

I've done a bit of testing on a fresh local install, on D10.4 and everything seemed to work fine, as expected.
 

HELP TESTING:
If you would like to help on this ticket, could you please help testing merge request MR!116?

Impacted areas and what to test:

• Admin Toolbar Search
• Admin Toolbar Hover, Focus, Click, Keydown ==> Interacting with the Toolbar.

 
We would also appreciate code reviews of MR!116.

But mostly: Applied a round of automated fixes with the --fix flag and fixed the remaining errors manually.
Changes to fix the 'unnamed functions' errors are probably the most impacting.
 

Moving this to Major as an attempt to attract attention and get more help on this issue.
Enforcing tight JS coding standards in the code base would allow detecting and preventing potential errors being introduced in submitted merge requests.

Back to Needs review.

Thanks in advance!