- Issue created by @dydave
- Merge request !75Issue #3407845: Applied automated eslint fixes and excluded external... → (Open) created by dydave
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
7 months ago Waiting for branch to pass - Status changed to Needs review
7 months ago 1:43pm 24 May 2024 - 🇫🇷France dydave
Quick follow-up on this issue:
A few additional commits were added to the current merge request MR!75 with a few comments, see above at #2.
But mostly, at this point:
Last build on MR!75: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/pipelines/181273- The ESLINT job now seems to be passing ✅
ESLINT job: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/1679160
- The PHPUnit Tests are passing as well 🟢 \o/
PHPUnit job: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/1679162
Added temporary commit to be reverted:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/75/dif...
ported from 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC , based on MR MR!68 to pass phpunit tests and add.gitlab-ci.ymlfile.
Revert this commit once these changes are merged in the development branch.
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!75 and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on merge request MR!75 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - The ESLINT job now seems to be passing ✅
- Status changed to RTBC
5 months ago 6:27am 29 July 2024 - 🇮🇳India rajeshreeputra Pune
Changes looks good, CI passing, can we get it merged? this will unblock the Drupal 11 compatibility issue - 📌 Add Drupal 11 support Needs review .
Thanks! - Status changed to Needs review
5 months ago 2:33pm 2 August 2024 - 🇫🇷France dydave
Rebased MR!75 on 3.x with gitlabci tests and required eslint job to pass.
✅ Merge request seems to complete successfully with all ESLint validation errors fixed, see:
- MR: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/pipelines/241728
- ESLint: https://git.drupalcode.org/issue/admin_toolbar-3449577/-/jobs/2315350
Back to Needs review for more reviews, testing and feedback.
Thanks! - 🇺🇸United States japerry KVUO
Because our tests don't have great coverage, I'd want to ensure this is manually tested a bit before committing. I've had issues where seemingly innocent js linting changes actually broke modules before.