Add Drupal 11 support

Shouldn't the default test be against Drupal 10 and PHP 8?

The 11.x branch isn't actually Drupal 11, it's 10.2. I asked in slack too, but it seems very weird to me that contrib would be forced to make itself pseudo-compatible with D11 (there will almost certainly be breaking changes in the real D11, which would result in old releases of contrib being marked compatible when they actually arent). Maybe we can set up a branch alias or something for composer?

And IMHO default testing should be against the lowest supported version, so that makes sense to me.

Thanks for that important piece of information @berdir. But it does say 11 many places, fx composer.json:

        "drupal/core-composer-scaffold": "^11",
        "drupal/core-project-message": "^11",
        "drupal/core-recommended": "^11",

You can install it via Composer:

$ composer create-project drupal/recommended-project:^11@dev test
Creating a "drupal/recommended-project:^11@dev" project at "./test"
Installing drupal/recommended-project (11.x-dev f6dbdb06676ea159c65f6912f64b8bfbef89d07a)
  - Downloading drupal/recommended-project (11.x-dev f6dbdb0)
[...]

Also on the Status page (/admin/reports/status):

Drupal Version

11.0-dev

But if 11 is really 10.2, is there an issue about it, and when it will get fixed? It seems like a pretty big deal ...

See https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... → .

Yes, thanks @berdir I also found that page this morning and have created 📌 Clarify that current version 11 is 10.2 Postponed .

I guess this can wait until the real Drupal 11.x is released, so changing status.

I was reminded about this issue today, after creating a Drupal instance with Git, running the standard command, which gets you Drupal 11.x branch by default:

git clone https://git.drupalcode.org/project/drupal

What would be the best way to allow installing Admin Toolbar in the current default 11.x branch, if it is not committing this patch?

As of today ~200 modules support Drupal 11 → .

@berdir and @ressa,

• It appears that the branch 11.x corresponds to Drupal 11, as indicated by the Drupal version being displayed as 11.0-dev in the status reports.
• Upon applying changes to the Admin Toolbar module for Drupal 11 compatibility, which involved adding ^11 in the .info.yml files, the modules became compatible and could be enabled with Drupal 11.x.
• Currently, the Admin Toolbar functions correctly with 11.x.

Please inform me if I have overlooked anything.
Thanks

Adding patch please review.

@chaitanyadessai: There is a Gitlab patch and MR already:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/57

I've tested shared MR- MR- MR !57 mergeable on Drupal version- 11.0-dev. The patch was applied successfully and looks good to me.

Testing Steps:

• Add/download Module "Admin Toolbar" in Drupal 11.
• Go to Extend module> You can see the compatibility error. Attached before result.
• Download this share MR and Apply.
• Go back to the Extend module and re-verify/Install the Admin Toolbar.

Testing Results:
After applying the patch, the compatibility error was removed & I was able to install the Admin toolbar module on drupal-11, and working fine form. Added after results. RTBC++

Adding workaround in Issue Summary, until we get Drupal 11 support.

Increasing to Major, since Drupal 11 may be released already in June 2024.

Should probably first migrate to GitlabCI, and then we can enable next major testing. Blindly committing this when tests are apparently failing doesn't seem like a good idea.

Yes, getting Gitlab CI to work sounds good.

Looks like real D11 has now been ready to work on for a couple of weeks so maybe time on un-postpone ?

@fgm this is postponed on 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC , seems consensus is that needs to be commited first.

Rebased with work from 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC and added D11 support. Requesting review.

Last 4 commits needs to be reverted as it is covered in https://www.drupal.org/project/admin_toolbar/issues/3407845 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC (Gitlab template, PhpCS, PHPStan) and even ESLINT is also fixed in a separate issue https://www.drupal.org/project/admin_toolbar/issues/3449577 📌 GitlabCI: Fix ESLINT validation errors Active
And agree with @berdir mentioned on #15, lets wait to merge issue-3407845 (Gitlab template) and its child issue(Fix ESLint) then we can enable OPT_IN_TEST_NEXT_MAJOR and do the needful changes further.

@ankitv18 - As referenced in my previous comment #20 📌 Add Drupal 11 support Needs review , the commits have been cherry-picked from 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC . Subsequently, we have added changes related to Drupal 11 compatibility. Once this merge request, or the one from 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC , is accepted, updating the fork should suffice.

Regarding ESLINT issue 📌 GitlabCI: Fix ESLINT validation errors Active , please note that it has not been addressed in this merge request.

With response of #22 https://www.drupal.org/project/admin_toolbar/issues/3363604#comment-1561... 📌 Add Drupal 11 support Needs review , I guess it's maintainer call how to manage this and related tickets.
Pipelines are passing hence moving this ticket into RTBC

Can you merge it with the stable branch too?

Drupal 11 will be released late July 2024, so it would be great to get this patch committed to dev, and released officially shortly thereafter.

Hello @adriancid,

You are requested to update us on your plans to release a pre/stable version of admin_toolbar that will make it possible to release an acquia_cms_toolbar → module D11 compatible. Thanks in Advance!

Drupal 11 is very close now, about two weeks:

Week of July 29, 2024 (UTC) | Drupal 11.0.0 released.

https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... →

Hello @adriancid @eme @fethi.krout @matio89 @Emerya.thomas,

Please accept my apologies for bothering you, but I would appreciate it if you could release a Drupal 11 compatible version as we have put in a great deal of effort to fix the compatibility issues. If you are no longer maintaining this, please add me as a maintainer, so we can provide support for Drupal 11 customers that will be very helpful in the long run.

Thanks!

Thank you for your kind offer @vipin.mittal18, I hope you can be added as a maintainer, to speed things up.

This might be a good candidate for the Project Update Working group. We can expedite the fixes without needing to add maintainers.

I do have concerns however that this issue is smashing different issues (phpcs, phpstan, cspell, etc) with D11 compatibility. Especially since tests are failing now due to some method signature issues (that need checking to make sure BC works with D9.5.

Following-up with the last comments (in particular #32), it would seem the previous merge requests would include more changes than necessary in order to fix this particular issue (compatibility with D11) and they have been broken into separate tickets with smaller merge requests, see:

• PHPUnit: 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC (Major)
• Stylelint: 📌 GitlabCI: Fix Stylelint validation errors RTBC
• CSpell: 📌 GitlabCI: Fix CSPELL validation errors Needs review
• PHPCS and PHPStan: 📌 Fix the issues reported by phpcs RTBC and 🐛 Fix issues reported by phpcs. RTBC
• ESLint: 📌 GitlabCI: Fix ESLINT validation errors Active

 
Therefore, all the changes related with any of these jobs have been removed in this new merge request MR!88 as an attempt to limit the changes to the bare minimum required for this particular issue:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/88/diffs

To test the D11 compatibility changes the 2 following other issues were merged into branch 3363604-add-d11-support-with-3407845:

• Fixed Tests: 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC (required) - MR!83
• D11 compatibility for FunctionJavascript tests: 🐛 Menu hover is broken on core 11.x Needs review - MR!87

 
✅ The tests seem to be passing, see:
https://git.drupalcode.org/issue/admin_toolbar-3363604/-/pipelines/232499

Extended tests coverage would still have to be added in merge request (MR!88), or cherry-picked from:
https://git.drupalcode.org/issue/admin_toolbar-3363604/-/commit/cb659bb0...

Otherwise, at this point, this MR "should" contain the minimum amount of changes to Add Drupal 11 support, thus moving back issue to Needs review.

At least this should allow unblocking users who would like to install releases with composer and give more time to maintainers to address related validation job tickets, which might accelerate the validation process of these changes.

Thanks in advance for the reviews and feedback!

Great work with separating the different tasks, and focusing on the necessary ones, thanks @DYdave!

On Acquia's Drupal 11 project deprecation status page, Admin Toolbar is the most popular project, not yet Drupal 11 ready.

Almost all of the 30 most popular projects are Drupal 11 ready, which is amazing. Webform → and Paragraphs → still need some work, so feel free to join in, and help get them D11 ready.

Tagging issue to make the link on Acquia's Drupal 11 project deprecation status page work.

It appears that all issues mentioned at #35 are marked "RTBC" with all test cases passing and then MR !57 can be merged.

japerry → changed the visibility of the branch 3.x to hidden.

japerry → changed the visibility of the branch 3363604-d11-ready to hidden.

japerry → changed the visibility of the branch 3363604-add-d11-support-with-3407845 to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

dydave → closed merge request !80