Add Drupal 11 support

Shouldn't the default test be against Drupal 10 and PHP 8?

The 11.x branch isn't actually Drupal 11, it's 10.2. I asked in slack too, but it seems very weird to me that contrib would be forced to make itself pseudo-compatible with D11 (there will almost certainly be breaking changes in the real D11, which would result in old releases of contrib being marked compatible when they actually arent). Maybe we can set up a branch alias or something for composer?

And IMHO default testing should be against the lowest supported version, so that makes sense to me.

Thanks for that important piece of information @berdir. But it does say 11 many places, fx composer.json:

        "drupal/core-composer-scaffold": "^11",
        "drupal/core-project-message": "^11",
        "drupal/core-recommended": "^11",

You can install it via Composer:

$ composer create-project drupal/recommended-project:^11@dev test
Creating a "drupal/recommended-project:^11@dev" project at "./test"
Installing drupal/recommended-project (11.x-dev f6dbdb06676ea159c65f6912f64b8bfbef89d07a)
  - Downloading drupal/recommended-project (11.x-dev f6dbdb0)
[...]

Also on the Status page (/admin/reports/status):

Drupal Version

11.0-dev

But if 11 is really 10.2, is there an issue about it, and when it will get fixed? It seems like a pretty big deal ...

See https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... → .

Yes, thanks @berdir I also found that page this morning and have created 📌 Clarify that current version 11 is 10.2 Postponed .

I guess this can wait until the real Drupal 11.x is released, so changing status.

I was reminded about this issue today, after creating a Drupal instance with Git, running the standard command, which gets you Drupal 11.x branch by default:

git clone https://git.drupalcode.org/project/drupal

What would be the best way to allow installing Admin Toolbar in the current default 11.x branch, if it is not committing this patch?

As of today ~200 modules support Drupal 11 → .

@berdir and @ressa,

• It appears that the branch 11.x corresponds to Drupal 11, as indicated by the Drupal version being displayed as 11.0-dev in the status reports.
• Upon applying changes to the Admin Toolbar module for Drupal 11 compatibility, which involved adding ^11 in the .info.yml files, the modules became compatible and could be enabled with Drupal 11.x.
• Currently, the Admin Toolbar functions correctly with 11.x.

Please inform me if I have overlooked anything.
Thanks

Adding patch please review.

@chaitanyadessai: There is a Gitlab patch and MR already:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/57

I've tested shared MR- MR- MR !57 mergeable on Drupal version- 11.0-dev. The patch was applied successfully and looks good to me.

Testing Steps:

• Add/download Module "Admin Toolbar" in Drupal 11.
• Go to Extend module> You can see the compatibility error. Attached before result.
• Download this share MR and Apply.
• Go back to the Extend module and re-verify/Install the Admin Toolbar.

Testing Results:
After applying the patch, the compatibility error was removed & I was able to install the Admin toolbar module on drupal-11, and working fine form. Added after results. RTBC++

Adding workaround in Issue Summary, until we get Drupal 11 support.

Increasing to Major, since Drupal 11 may be released already in June 2024.

Should probably first migrate to GitlabCI, and then we can enable next major testing. Blindly committing this when tests are apparently failing doesn't seem like a good idea.

Yes, getting Gitlab CI to work sounds good.

Looks like real D11 has now been ready to work on for a couple of weeks so maybe time on un-postpone ?

@fgm this is postponed on 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC , seems consensus is that needs to be commited first.

Rebased with work from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC and added D11 support. Requesting review.

Last 4 commits needs to be reverted as it is covered in https://www.drupal.org/project/admin_toolbar/issues/3407845 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC (Gitlab template, PhpCS, PHPStan) and even ESLINT is also fixed in a separate issue https://www.drupal.org/project/admin_toolbar/issues/3449577 📌 GitlabCI: Fix ESLINT validation errors Active
And agree with @berdir mentioned on #15, lets wait to merge issue-3407845 (Gitlab template) and its child issue(Fix ESLint) then we can enable OPT_IN_TEST_NEXT_MAJOR and do the needful changes further.

@ankitv18 - As referenced in my previous comment #20 📌 Add Drupal 11 support Needs work , the commits have been cherry-picked from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC . Subsequently, we have added changes related to Drupal 11 compatibility. Once this merge request, or the one from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC , is accepted, updating the fork should suffice.

Regarding ESLINT issue 📌 GitlabCI: Fix ESLINT validation errors Active , please note that it has not been addressed in this merge request.

With response of #22 https://www.drupal.org/project/admin_toolbar/issues/3363604#comment-1561... 📌 Add Drupal 11 support Needs work , I guess it's maintainer call how to manage this and related tickets.
Pipelines are passing hence moving this ticket into RTBC

Can you merge it with the stable branch too?

Drupal 11 will be released late July 2024, so it would be great to get this patch committed to dev, and released officially shortly thereafter.