- Issue created by @dydave
- Merge request !84Issue #3462195 by DYdave: Stylelint on GitlabCI: Fixed all validation errors. → (Merged) created by dydave
- Status changed to Needs review
4 months ago 9:08pm 17 July 2024 - 🇫🇷France dydave
Quick follow-up on this issue:
Changes from MR!68 were ported to this ticket's merge request MR!84, from related issue 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC .
Fixed all stylelint validation errors based on report and required job to pass.
Last pipeline with stylelint job completing successfully:
- MR pipeline: https://git.drupalcode.org/issue/admin_toolbar-3462195/-/pipelines/227184
- Stylelint job: https://git.drupalcode.org/issue/admin_toolbar-3462195/-/jobs/2152031
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!84 and let us know if there would be any more work needed.Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - Status changed to RTBC
4 months ago 11:53am 22 July 2024 - 🇮🇳India rajeshreeputra Pune
Stylelint gook good, CI passing, can we get it merged? this will unblock the Drupal 11 compatibility issue - 📌 Add Drupal 11 support Needs review .
- First commit to issue fork.
-
japerry →
committed a58a23dd on 3.x authored by
DYdave →
Issue #3462195: GitlabCI: Fix Stylelint validation errors
-
japerry →
committed a58a23dd on 3.x authored by
DYdave →
- Status changed to Fixed
4 months ago 4:09pm 2 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.