- Issue created by @dydave
- Merge request !86Issue #3463378: CSpell on GitlabCI: Fixed all validation errors such as typos... → (Merged) created by dydave
- 🇫🇷France dydave
Quick follow-up on this issue:
Changes from MR!68 were ported to this ticket's merge request MR!86, from related issue 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC .
Fixed all cspell validation errors based on report and required job to pass.
Last pipeline with cspell job completing successfully:
- MR pipeline: https://git.drupalcode.org/issue/admin_toolbar-3463378/-/pipelines/232274
- CSpell job: https://git.drupalcode.org/issue/admin_toolbar-3463378/-/jobs/2207580
Important note:
The usernames could potentially be ignored by default if theMaintainers
sections of eachREADME.md
files could be moved toMAINTAINERS.txt
files, the same way it has been done here:
https://git.drupalcode.org/project/token/-/merge_requests/76/diffs#diff-...But since the formatting is currently using markdown (
.md
files), we thought it would be better to stick with what we currently have and perhaps consider in a future issue movingMaintainers
sections to specificMAINTAINERS.md
files.
(Not sure if the format is already supported and recommended for contributed modules)The up side of using
MAINTAINERS
files is that we wouldn't have to maintain these user names in an additional file, see:
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/86/dif...
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!86 and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - Status changed to Needs review
4 months ago 4:03pm 23 July 2024 - Status changed to RTBC
4 months ago 12:43pm 25 July 2024 - 🇮🇳India ankitv18
Marking this RTBC considering the cspell pipeline is fixed: https://git.drupalcode.org/issue/admin_toolbar-3463378/-/jobs/2207580
And also great to see configured cspell to fail the pipeline if any mistake is there. - 🇮🇳India rajeshreeputra Pune
Changes looks good, CI passing, can we get it merged? this will unblock the Drupal 11 compatibility issue - 📌 Add Drupal 11 support Needs review .
Thanks! - Status changed to Needs review
4 months ago 2:56pm 2 August 2024 - 🇫🇷France dydave
Rebased MR!86 on 3.x with gitlabci tests and required cspell job to pass.
✅ Merge request seems to complete successfully with all CSpell validation errors fixed, see:
- MR: https://git.drupalcode.org/issue/admin_toolbar-3463378/-/pipelines/241853
- CSpell: https://git.drupalcode.org/issue/admin_toolbar-3463378/-/jobs/2316975
Back to Needs review for more reviews, testing and feedback.
Thanks! - First commit to issue fork.
- Status changed to Fixed
4 months ago 9:36pm 2 August 2024 - 🇺🇸United States japerry KVUO
Personally, I'm not a fan of cspell. However, I will commit this since it is green. Not going to make it a failing test though.
Automatically closed - issue fixed for 2 weeks with no activity.