[Meta] Roadplan for Admin Toolbar 3.7

Just adding issues as related :)

Or ... in light of the "Supported" thing, this Meta issue could also be aimed at 3.6.1, to not have to include three versions on the project page? (3.5, 3.6, and 3.7) Unless there are breaking changes, and then it's probably needed ...

Sure @ressa, no problem at all 🙂

Of course we're going to release "patch" versions of the 3.6 branch if there are any urgent issues to fix 👌
But I thought this would be straight forward enough not to require a specific ticket to request help for testing and/or plan for big changes.

I have created this issue mostly for ✨ Tabbing order does not satisfy 508 accessibility requirements Active which is a very big ticket with a large amount of changes .... so I thought that could potentially require another new minor version.
Also, we "could" start considering dropping support for version below 10.3 in the next minor, since by the month of August we should be about a year away from D10 EOL....

But in any case, I wouldn't mind at all changing the target version, the title of this issue, or anything in the coming scope of work 👌

I just created this issue really to try to get a list of priorities organized for the coming months.

Feel free to make any changes, suggestions or modifications to this issue or the suggested scope of work, we would be very grateful for your help, as usual 🙏
Thanks in advance!

Thanks for clarifying @dydave, I wasn't aware how many changes there is in the tabbing issue, but it does look like there a lot. Great to see this improvement is coming along!

About dropping support for versions below Drupal 10.3, I have no opinion -- but if it makes the code easier to maintain, it's worth considering, since then only PHP 8.3 and up needs to be supported → .

So I agree, the target version for the tasks here might change, but it could also stay as 3.7 🙂

Adding a minor task :)

Small change to add in one of the next MRs to be merged:
#3527462-10: Import of strings skipped due to malformed HTML tag
→

A single lingering untranslated string was found in the interface, which is "milliseconds" here:

$ grep -rinoE '.{0,10}millis.{0,10}' .
./src/Form/AdminToolbarSettingsForm.php:136:ffix' => 'milliseconds',

It just needs to get wrapped in t(), and all is well:

'#field_suffix' => $this->t('milliseconds'),

See source code:
https://git.drupalcode.org/project/admin_toolbar/-/blob/3.6.1/src/Form/A...

The change suggested above at #7 was added to issue 🐛 Uncaught TypeError: toolbarElement.querySelector(...) is null Active and merged in with MR !163.

It can be scratched off our list 👌

Thanks @dydave, nice that you remembered this lingering detail, it's good to get it done. Have a great day 🙂

Thanks a lot @ressa and sorry for the late reply 😅

I have recently focused on a bit of refactoring for the Admin Toolbar Search module and would greatly appreciate some help, if you get a chance 🙏

I have added the following ticket to the list:
📌 Admin Toolbar Search: Remove dependency on Admin Toolbar Tools Active
which has a merge request, ready to be reviewed at anytime.
I've also tried to document a bit the changes, in terms of technical or user interface impacts.

I will most likely break down more "refactoring" into multiple issues, mostly around tests, the module file and the JS, for which your help would also be definitely warmly welcome 🙂

In any case, feel free to let us know if you have any feedback, suggestions or other ideas on the added issues, it would be a great help as always.
Thanks in advance!

No problem at all @dydave, thanks for keep on working on improving the Admin Toolbar code base and structure, I am very grateful! I have just taken a look at the decoupling issue, and will gladly look at other relevant issues.

So feel free to add them here, and I'll attempt to help with reviewing them, so long as my capabilities allow it 🙂

Super nice of you @ressa, as always! 🙏

I was able to make a bit of progress on the refactoring of the admin_toolbar_search module, as I mentioned previously and have created the first issue: 📌 Automated tests: Merge several Functional test classes Active .

This is mostly some code clean-up: trying to optimize a bit the files in the code base.
The only impacted files are modules' Functional tests, but it could be good if you could just take a quick look at the MR and ticket to see if everything checks out or if I could have missed anything.

Next on the list should be module's FunctionalJavascript tests 👍
Let's keep consolidating the Tests coverage before proceeding with refactoring modules' files 😅

Once again, let me know if you spot anything or would have any suggestions, your feedback if always very helpful 🙂
Thanks in advance!