Allow shortcut key to be configurable

We are accepting merge requests if anybody is interested in working on this.

Thanks!

So nice @ressa, as usual, of you to keep the ticket well documented based on the work from other issues 🙏

Adding here a few additional helpful comments and suggestions:

#3527344-12: New keyboard shortcuts do not work on MacOS → :

3) More advanced mac users will know that alt = option / ⌥, but ideally it'd show "⌥ + a" instead of "alt + a". If this would be trivial to change based on parsing user agent strings that'd be useful. More of a minor/optional QoL issue.

#3527344-13: New keyboard shortcuts do not work on MacOS → :
Issue summary:

Side note: When the search shortcut is disabled in the modules settings, the search input placeholder text still includes "(Alt+a)". Probably needs it's own issue.

I agree that the shortcut "tip" text could be improved — it shouldn't even be there if the shortcut has been disabled

#3527344-15: New keyboard shortcuts do not work on MacOS → : Concerning the form settings for the hide/show toolbar shortcut:

it is a little odd it's tucked at the bottom of "Toolbar sticky behavior", since it's only tangentially related to that. Either the header should be something like "Toolbar visibility" or it should be in it's own section. It also wouldn't be terrible if the keyboard shortcuts were just in their own section instead of below what they're related to.

 

Let's see how we could organize and include these changes in the next merge requests.

Thanks again everyone for all the great help!