Make the menu dropdown as scrollable.

I have tested the patch with drupal version 9.5.3. Patch doesn't applied. getting some errors like this
Checking patch css/admin.toolbar.css...
error: while searching for:
border-right: 1px solid #ddd;
}

.toolbar .toolbar-tray-horizontal ul ul li.menu-item:first-child {
border-top: 1px solid #ddd;
}

.toolbar-tray-horizontal li.menu-item--expanded.hover-intent ul ul,

error: patch failed: css/admin.toolbar.css:34
error: css/admin.toolbar.css: patch does not apply
Checking patch js/admin_toolbar.hoverintent.js...
error: while searching for:
// Other wise we get unwanted behaviour where menu items are expanded while already in hovering other ones.
$(this).parent().find('li').removeClass('hover-intent');
$(this).addClass('hover-intent');
},
out: function () {
$(this).removeClass('hover-intent');
},
timeout: 250

error: patch failed: js/admin_toolbar.hoverintent.js:6
error: js/admin_toolbar.hoverintent.js: patch does not apply

#42 is applied correctly in 9.5.3 and in my opinion works as expected.

Thanks for providing this solution.

Tried testing #42 with v3.3.0 on Drupal 10.1.x-dev.
On applying patch, getting below:

Skipped patch 'css/admin.toolbar.css'.
Skipped patch 'js/admin_toolbar.hoverintent.js'.

Rerolled #40 for the v3.3.1 - 3.x-dev 50ff7eb6 commit. Tested with Drupal 9.5.8.

Tried to apply patch #46 it is working fine for add content menu but not working properly for last content type in content type list for content type I have shared video.
need to work on it.

We've changed a little bit the patch so it can apply to Claro but also to Gin and works a little better with submenus as shown in #47 video.

We haven't tested yet on RTL theme and also the vertical admin menu bar for Gin is not functional, so keeping status as Need work.

patch #46 works for me in drupal 9.4.10 Panopoly thank you.

Patch #46 could not be applied in admin_toolbar 3.4.1 and drupal 9.5.10.
Instead #48 was applied correctly and seems to work correctly.

#48 works well for us on Drupal 10.1.3 and Admin Toolbar 3.4.1

Indranil Roy → made their first commit to this issue’s fork.

I have just made a couple of theming changes based on #48 to improve the appearance. Using Claro theme and Drupal 9.5.11.

I rerolled patch #48 for Admin Toolbar 3.5.0 on Drupal 10.3.1

The attached patch does not build on the currently dominant approach to this issue (#54 at the moment), and allows the sub-menus to scroll (rather than expand laterally) as mentioned in the original request. It introduces a new override template with an added container div around the ul's to achieve the desired result. This required some adjustments to the CSS and Javascript, including a direct copy/tweak of some of the core toolbar module code.

This is my first contribution, so kindly let me know if I've missed any steps or approached the process incorrectly. Based on 3.5.1 running on core 10.3.6.

Hi
I've tested patch #55 on Drupal 10.3.x
The patch is applied successfully...

The menu dropdown is scrollable after applied patch

Screenshots

Here's a reroll of the patch in #54 against admin_toolbar:3.6.0

Thanks a lot everyone for the great work on this issue, all the contributed patches and comments! 🙏

Looks like there is already a lot of history in this issue, going back to 2017 😅
 

Let's try summing up the current status:

Currently, this issue contains two different implementations to achieve a similar goal:

Improve the way dropdown menus with many items are currently displayed, so they could be visible.

1 - Multi-column menu dropdown: MR !150
Based on patch #59 which is the latest version of the very first implementation of this feature, when the ticket was initially created, so it has quite a lot of reviews and testing feedback.

Patch MR!150 displays long lists of items in dropdown menus broken down into multiple columns, so they could be displayed horizontally and fit the viewport, see a screenshot of the result:

2 - Scrolling menu dropdown: MR !151
Based on patch #55 which is a more recent approach of the feature with fewer exchanges, reviews or feedback, but seems like a very valid approach as well.

Patch MR !151 displays long lists of items in dropdown menus with a fixed height and a scrollbar, to be displayed when scrolling up or down the menu dropdown, see a screenshot of the result:

At this point, I have not started any kind of code review or careful testing of any of these merge requests, but only very superficial testing locally and they both seemed to work very well 👌
Great job everyone! 🥳

OK, first of all, we need to clarify what implementation should be chosen in this issue:

What solution should be implemented exactly? Solution 1 or 2 or something else?

Keep in mind, it is always possible to make any of these solutions configurable through the backend, for example, to enable/disable or select one method or another (select list, checkbox, radios, etc...).
It is also possible to break down this issue into multiple smaller issues with different types of implementations.

But if we would like to make any kind of serious progress here, we should start by having a clear vision of the results that would be expected by the changes in this issue.

What would be your suggestions on this?

Otherwise from a coding standpoint, MR !150 is much less intrusive than MR !151 which changes the HTML structure and classes of the menu with a twig template override....
So we would probably need to rework some of the code implementations once we have a better idea of the expected result.

Keeping this issue in Needs review for now, as an attempt to attract more attention, get more feedback, reviews of the new merge requests and replies to the questions in this comment.

Feel free to let us know if you have any questions or concerns on any aspects of this comment, the merge request or this issue in general, we would surely be glad to help.
Thanks in advance! 🙂

dydave → changed the visibility of the branch 3.x to hidden.

Reroll of scrolling patch in #55 for admin_toolbar 3.6.0.