Contrib.social

Update taxonomy term base fields (parent and weight) to be configurable on form display

Open on Drupal.org →
Created on 13 July 2020, almost 5 years ago
Updated 15 January 2024, over 1 year ago

Problem/Motivation

1. As stated in #2751001: Expose configuration for Relation → , users, such as site builders, are unable to control the visibility of Relations for a term via the Manage form display page or the taxonomy edit page. Some taxonomies may not require parent-child relations and therefore would not require the Relations for a term to be displayed on the create/edit page.

2. Related to the first point, being unable to control the visibility of Relations for a term, there is an issue when having a taxonomy with large sets of terms. Due to the backend form code of ensuring that A term can't be the child of itself, nor of its children, \Drupal\taxonomy\TermStorageInterface::loadTree() and \Drupal\taxonomy\TermStorageInterface::loadParents() are called, which can cause memory errors, WSOD, etc. Based on where this process is, a hook_form_alter() is too late to prevent these functions from being called. There is an if statement and a comment that states that switching taxonomy.settings:override_selector to TRUE would skip the calling of these functions, but this isn't very user friendly to a site builder and was not super easy to decipher prior to digging in the code.

Proposed resolution

1. Convert the Parent and Weight Base Fields to be available and controlled via the Manage form display page for Taxonomy Terms in core/modules/taxonomy/src/Entity/Term.php
2. Move the Relations form functionality to a hook_form_alter() in taxonomy.module
3. Remove the Relations form functionality from core/modules/taxonomy/src/TermForm.php

Remaining tasks

Run tests and potentially modify test cases

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
Taxonomy  →

Last updated 3 days ago

  • Maintained by
  • 🇺🇸United States @xjm
  • 🇬🇧United Kingdom @catch
Created by

🇨🇦Canada nord102

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇸🇮Slovenia g1smo

    Re-rolled D9 patch from #18 so that it work on Drupal 10.2.1

    Looking forward to getting this merged. It's necessary when trying to change the parent term of a large vocabulary.

  • Comment over 1 year ago →
    🇸🇮Slovenia g1smo

    Re-rolled the patch the patch from #18 to work on Drupal 10.2.1

  • Comment over 1 year ago →
    🇸🇮Slovenia g1smo

    I've also created an issue fork.

  • Merge request !6200Issue #3158934: Update taxonomy term base fields (parent and weight) to be... → (Open) created by g1smo
  • Pipeline finished with Failed
    over 1 year ago
    Total: 184s
    #78157
  • Pipeline finished with Failed
    over 1 year ago
    Total: 187s
    #78165
  • Pipeline finished with Failed
    over 1 year ago
    Total: 202s
    #78195
  • Pipeline finished with Failed
    over 1 year ago
    Total: 170s
    #78201
  • Pipeline finished with Failed
    over 1 year ago
    Total: 757s
    #78207
  • Pipeline finished with Failed
    over 1 year ago
    Total: 490s
    #78225
  • Pipeline finished with Failed
    over 1 year ago
    Total: 641s
    #122577
  • Pipeline finished with Failed
    over 1 year ago
    Total: 687s
    #137378
  • Pipeline finished with Canceled
    about 1 year ago
    Total: 224s
    #178575
  • Pipeline finished with Failed
    about 1 year ago
    Total: 546s
    #178581
  • Comment about 1 year ago →
    akshay9

    After applying this "taxonomy_base_polja.patch" patch, all the existing selection of parent term for existing vocabularies are no longer there. As it is considered as new field. Any solutions to keep the previous selections of parent terms for existing taxonomy terms?

  • Comment 12 months ago →
    🇸🇮Slovenia g1smo

    @ashkay9
    Existing values should be there, this patch lets you change the parent term widget in "form display".
    Worked well for me on Drupal 10, which version are you on?

  • Comment 7 months ago →
    🇨🇦Canada nord102

    Re-rolled patch to apply to 10.3

  • Comment 12 days ago →
    🇵🇱Poland gugalamaciek

    #26 extended with configurable parent and weight on detail page, not just form display.

  • Comment 12 days ago →
    🇵🇱Poland gugalamaciek
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024