Account created on 13 July 2016, over 8 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡¦Canada nord102

Completed the survey!

πŸ‡¨πŸ‡¦Canada nord102

I would argue that Tags makes sense to be a plural.

My thought process is that if we think of a Taxonomy Term to be the equivalent to a Node, then a collection(taxonomy) of Terms is equivalent to a view of Nodes, where the latter two are plural. When you name a view, it's typically the plural (E.g. Article content type will have a view of Articles). I think the same logic would apply to Taxonomy, where In this case, Tags would represent the collection(taxonomy) of Tag Terms, where each term is the singular and the collection(taxonomy) is the plural.

πŸ‡¨πŸ‡¦Canada nord102

I applied the patch from #5, but I noticed that it caused file uploads to not work as expected because file/file.js was still trying to trigger and act on mousedown.

I have updated the patch from #5 to include changing mousedown to mouseup for file/file.js as well.

πŸ‡¨πŸ‡¦Canada nord102

Re-rolled #18 for the latest version of the module 8.x-2.3

Noting that #19 was trying to add things that are currently being worked on here #3057444: Error on Layout Builder Manage Layout screen β†’

πŸ‡¨πŸ‡¦Canada nord102

For some reason, the configuration that is being used by core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php > initializeView() has empty view information in $this->getConfiguration()['view']. The correct view information seems to be in $this->getConfiguration()['handler_settings']['view'] instead.

I've created a patch that will use the ['handler_settings']['view'] as a fallback when ['view'] is NULL

πŸ‡¨πŸ‡¦Canada nord102

I have created a fork and MR that leverages filter_var as the Autoplay and Responsive Video setting values are set to strings (e.g. "true") which result in FALSE without the filter_var

πŸ‡¨πŸ‡¦Canada nord102

I've created a new MR based on the latest release and leveraging the work done in #7. I have closed the other MR as it was out of date.

One thing I noticed is that PasswordStrengthMatcherPluginManager.php references two classes that don't exist anymore:

  • Plugin/PasswordStrengthMatcher
  • Drupal\password_strength\PasswordStrengthMatcherInterface

So that's something we should probably fix as well

πŸ‡¨πŸ‡¦Canada nord102

nord102 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada nord102

@greggles Ah, I didn't see that you had already tagged it, awesome!

πŸ‡¨πŸ‡¦Canada nord102

@greggles Thank you!

πŸ‡¨πŸ‡¦Canada nord102

@joseph.olstad I should be able to get a tagged release out tomorrow

πŸ‡¨πŸ‡¦Canada nord102

@greggles This looks good to me

πŸ‡¨πŸ‡¦Canada nord102

Hey @SAVEL

Sounds good, I'll get a D10 roadmap issue going and link it to this issue once I do. I'll likely try to get a bunch of changes on that issue all at once, unless there is already an issue for something

Stay tuned!

πŸ‡¨πŸ‡¦Canada nord102

Patch #48 worked for me on version 2.1.3 of the module

πŸ‡¨πŸ‡¦Canada nord102

I have reached out to https://www.drupal.org/u/savel β†’ on April 24 to review this issue

πŸ‡¨πŸ‡¦Canada nord102

That error message doesn't look like it has anything to do with the Config Ignore module.

I would encourage you to investigate a bit more into your site configuration as a whole.

πŸ‡¨πŸ‡¦Canada nord102

Thanks for the fix, looks like that was missed with the _roleassign_get_assignable_roles rework.

As for the Bulk Actions, it doesn't look like we currently have tests, but we should, that way it can catch things like this in the future. I'll make an new issue for that

πŸ‡¨πŸ‡¦Canada nord102

Re-rolled the previous patches to use the $block_plugin->label() and translate it properly.

πŸ‡¨πŸ‡¦Canada nord102

I have created a release for 2.0.0

πŸ‡¨πŸ‡¦Canada nord102

nord102 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada nord102

Setting to Needs work because we'll need tests cases to test the negate setting

πŸ‡¨πŸ‡¦Canada nord102

@svendecabooter yes, just trying to get a few more issues fixed and then I'll do a new release, aiming for the end of this week

πŸ‡¨πŸ‡¦Canada nord102

Although it looks like the CodeKarate link is working, as of right now, I changed this to link directly to YouTube in case the CodeKarate link stops working again in the future.

πŸ‡¨πŸ‡¦Canada nord102

Re-rolled the patch from #2 and formatted the code a little bit.

πŸ‡¨πŸ‡¦Canada nord102

Although there has been some documented steps in this thread, I am having trouble reproducing this. Can someone provide some clearer steps on how to reproduce as well as what version of core you're testing on?

πŸ‡¨πŸ‡¦Canada nord102

Re-rolled the patch from #2 to apply to the latest dev version

πŸ‡¨πŸ‡¦Canada nord102

Setting as Fixed since πŸ“Œ Automated Drupal 10 compatibility fixes Fixed has been merged in

πŸ‡¨πŸ‡¦Canada nord102

Thanks all for the contribution on this!

πŸ‡¨πŸ‡¦Canada nord102

I attempted to contact the current maintainer on March 8 through both Slack and the Drupal.org contact form, will wait for a reply.

πŸ‡¨πŸ‡¦Canada nord102

Just want to note that I also reached out via the contact form and slack to see if I could get ahold of the current maintainer and see if I can be promoted from co-maintainer to maintainer, that was my goal in my original ticket πŸ“Œ Offering to maintain RoleAssign Fixed , I will also update that ticket as well.

πŸ‡¨πŸ‡¦Canada nord102

@joseph.olstad

I've already cloned the repository, but it looks being added as a co-maintainer on drupal.org does not add you to the Project members list for the Git Repo (https://git.drupalcode.org/project/roleassign/-/project_members), hence my inability to push / merge MRs

I will follow the steps from https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β†’ to see if I can take over as a full maintainer

πŸ‡¨πŸ‡¦Canada nord102

@joseph.olstad

I am currently a co-maintainer on RoleAssign, but I do not have push / merge permissions, which limits how much I can help move things forward, I have also messaged the main maintainer to see if I can even get upgraded permissions to move things along.

πŸ‡¨πŸ‡¦Canada nord102

@dpagini

I was able to reproduce this with the following steps:

  1. Fresh install with Drupal core 9.5.3 and Drush version 10.6.1
  2. Composer require Config Override via composer require 'drupal/config_override:^2.0'
  3. Enable Config Override
  4. Run a drush command from the command line e.g. drush status

Result: Error specified in #5

πŸ‡¨πŸ‡¦Canada nord102

Tested the patch from the MR mentioned in #5

Can confirm it works as expected, removing the core key as well as properly updating the core_version_requirement key

Marking as RTBC

πŸ‡¨πŸ‡¦Canada nord102

Hey all,

Apologies for the delay on this, I will look into the RTBC issues and and getting a new release out this week.

πŸ‡¨πŸ‡¦Canada nord102

@stefanmz7

There are currently a few options to pick from:

  • Automatically generate the label and hide the label field
  • Automatically generate the label if the label field is left empty
  • Automatically prefill the label

Are you saying that these options aren't working as expected?

Please provide more detail and steps to reproduce the issue

Production build 0.71.5 2024