Facet title is using the facet source & facet name as title instead of using the facet label

This fixed the issue for me on 2.0.0-beta1. I'm bumping this issue to 2.x-dev because that's the latest version. However, it can be backported and the current time as well.

Using translations like this is not recommended:

$this->t($block_plugin->label())

Only string literals should be passed to t().

We need to change this.

Added patch by addressing #5, please review it.

It's been caused by 3255460 📌 'Facets to include' lists Summary facet that might not exist Fixed

For some reason the facet title had the source added, really unnecessary and broken front end UI

Re-rolled the previous patches to use the $block_plugin->label() and translate it properly.

Patch in #6 📌 Facet title is using the facet source & facet name as title instead of using the facet label Fixed is correct, Patch #8 📌 Facet title is using the facet source & facet name as title instead of using the facet label Fixed is unnecessarily translating a variable that should already handle it's own translation, there is no reason to pass this through t() unless there was some prefix/suffix text here.

Patch #6 is working for me, thanks.

This doesn't seem to work with translations.
This seems to work.

Patch #11 worked perfectly in our project (D10.1.4) to fix an issue with translations. Thanks!

Fixed.

Patch #11 applied, since it works with translations as well (I just tested it).

Unfortunately the change in patch #11 as released in 2.0.0-beta3 fails in the case of drupal/facets_range_dropdowns since $build['0']['#facet'] is not set. For now, I am using

if (isset($build['0']['#facet'])) {
  $title = $build['0']['#facet']->getName();
}
else {
  $title = $block_plugin->label();
}

$facets[] = [
  '#block_plugin' => $block_plugin,
  'title' => $title,
  'content' => $build,
  'attributes' => new Attribute($build['#attributes']),
];

Fixed the issue in #16 and released 2.0.0-beta4.

Thanks for that, working for me via 2.0.0-beta4.

Automatically closed - issue fixed for 2 weeks with no activity.