Button styles need reset to avoid inheriting from theme

Created on 5 May 2023, about 1 year ago

Updated 10 May 2023, about 1 year ago

Problem/Motivation

The accessibility work added in 3.3.1 added a button.toolbar-icon.toolbar-handle element to each menu item with children. It's not uncommon for themes to style button elements globally, and when they do these styles can leak into the admin toolbar buttons.

Proposed resolution

Add a CSS rule to reset all button styles in admin toolbar.

Remaining tasks

Create patch.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Closed: duplicate

Version

3.3

Component

Code

Created by

🇺🇸United States benabaird

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @benabaird
Comment about 1 year ago →
🇺🇸United States benabaird
I've added a CSS reset for all buttons inside admin toolbar. With reset:
Status changed to Needs review about 1 year ago5:47pm 5 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
17 pass
@benabaird opened merge request.
Status changed to Closed: duplicate about 1 year ago1:46pm 10 May 2023
Comment about 1 year ago →
🇨🇦Canada adriancid Montreal, Canada

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024