Contrib.social

Upgrade version 3.5.3 to 3.6 crashes site

Open on Drupal.org →
Created on 22 May 2025, about 1 month ago

Problem/Motivation

After the upgrade on D10.4.7 with PHP 8.3.20 the site crashed, a rollback solved the issue for now.

ArgumentCountError: Too few arguments to function Drupal\admin_toolbar_content\Plugin\Menu\RecentMenuLinkEntity::__construct(), 4 passed in /var/www/html/web/core/lib/Drupal/Core/Menu/MenuLinkDefault.php on line 54 and exactly 5 expected in Drupal\admin_toolbar_content\Plugin\Menu\RecentMenuLinkEntity->__construct() (line 28 of modules/contrib/admin_toolbar_content/src/Plugin/Menu/RecentMenuLinkEntity.php).

Drupal\Core\Menu\MenuLinkDefault::create(Object, Array, 'admin_toolbar_content.menu_links:content.einfache_seite_mit_datei_bild_fe.recent.entity.0', Array) (Line: 36)
Drupal\admin_toolbar_tools\Plugin\Menu\MenuLinkEntity::create(Object, Array, 'admin_toolbar_content.menu_links:content.einfache_seite_mit_datei_bild_fe.recent.entity.0', Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('admin_toolbar_content.menu_links:content.einfache_seite_mit_datei_bild_fe.recent.entity.0', Array) (Line: 194)
Drupal\Core\Menu\MenuLinkManager->createInstance('admin_toolbar_content.menu_links:content.einfache_seite_mit_datei_bild_fe.recent.entity.0') (Line: 130)
Drupal\Core\Menu\MenuLinkTree->createInstances(Array) (Line: 125)
Drupal\Core\Menu\MenuLinkTree->createInstances(Array) (Line: 125)
Drupal\Core\Menu\MenuLinkTree->createInstances(Array) (Line: 107)
Drupal\Core\Menu\MenuLinkTree->load('admin', Object) (Line: 118)
Drupal\toolbar\Controller\ToolbarController::preRenderGetRenderedSubtrees(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 875)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array) (Line: 283)
{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 282)
toolbar_get_rendered_subtrees() (Line: 295)
_toolbar_get_subtrees_hash() (Line: 168)
toolbar_toolbar()
call_user_func_array(Object, Array) (Line: 416)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'toolbar') (Line: 395)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('toolbar', Object) (Line: 415)
Drupal\Core\Extension\ModuleHandler->invokeAll('toolbar') (Line: 78)
Drupal\toolbar\Element\Toolbar::preRenderToolbar(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 875)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array) (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 94)
__TwigTemplate_1ec53ad6a7333b0ba5c399bab7377c8a->doDisplay(Array, Array) (Line: 388)
Twig\Template->yield(Array, Array) (Line: 344)
Twig\Template->display(Array) (Line: 359)
Twig\Template->render(Array) (Line: 51)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('core/themes/olivero/templates/layout/html.html.twig', Array) (Line: 348)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 491)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array) (Line: 158)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 153)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 263)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 130)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

Upgrade module on D10.4.7 from 3.5.3 to 3.6 (pulls in admin_toolbar_tools as well, same versions)

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.6

Component

Code

Created by

dgwolf

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dgwolf
  • Comment about 1 month ago →
    🇩🇰Denmark ressa Copenhagen

    Could it be a custom link (einfache_seite_mit_datei_bild_fe), causing this? I see this in the release notes:

    Breaking changes:

    The following changes are part of the reason why this new release was added as a new minor version (3.6.x), since they introduce backward compatibility (BC) breaking changes:

    Important: The module does not support anymore the implementation of a __construct method for any class extending class ExtraLinks, see issue #3514075 → .

    In other words, if any class extends module's ExtraLinks class and implements its own __construct method, the site will crash after upgrade.

    The issue above explains what would be the required code changes to fix these types of errors.

    https://www.drupal.org/project/admin_toolbar/releases/3.6.0 →

    Also, from another issue:

    [...] please make sure to run database updates because the config structure has changed, see also 🐛 Warning: Trying to access array offset on null in admin_toolbar_toolbar_alter() Active .

    From 🐛 Warning: Trying to access array offset on value of type null in admin_toolbar_toolbar_alter() (line 39 of C:\wamp64\www\SFDA-portal\Source\portal\web\modules\contrib\admin_toolbar\admin_toolbar.module) Needs work .

    Could missing database updates be the reason? From the top of the release notes:

    How to update? Requires running database updates (drush updb) which make changes to the active configurations of the module.

    It's recommended to run updates locally, before doing them on the live web site.

  • Comment about 1 month ago →
    🇫🇷France dydave

    @dgwolf:

    It seems you are using the contrib module Admin Toolbar Content → (see admin_toolbar_content in the stack trace in the issue summary), which "could" be the problem here ...

    Sorry, but I didn't have time to test this myself, but it would be worth looking into:
    https://git.drupalcode.org/project/admin_toolbar_content/-/blob/2.0.x/sr...

    Just make sure you have the latest versions installed in general, for this module as well... maybe this could help fixing the issue in your case.

    Otherwise, I'll try taking a look a bit later when I have more time.

    Thanks in advance!

  • Comment 24 days ago →
    🇫🇷France dydave

    @dgwolf:

    This issue was also reported in the Admin Toolbar Content → module, see:
    📌 Compatibility with Admin Toolbar 3.6.0 Active
    where a patch was submitted in issue's merge request MR !37.

    Could you please try testing again with the suggested patch for admin_toolbar_content?

    Could we maybe try fixing this issue in the Admin Toolbar Content → module instead?
    Do you think we could consider Admin Toolbar is working fine and that the issue is rather with Admin Toolbar Content?

    Otherwise, as a "personal" advice:
    It would seem the module Admin Toolbar Content → is Minimally maintained with No further development, a rather limited user base (about 500 reported installs) and maintainers are now directing users to Navigation Extra → as a potential replacement.

    Therefore, if you have a choice, I would recommend to try moving away from the Admin Toolbar Content module to another solution, since the module doesn't necessarily seem to be very well maintained.

    Since a solution was provided in this comment, moving issue to Needs review for now, as an attempt to attract more attention, reviews, testing and reporting feedback.

    Feel free to let us know if you have any questions on this issue or the changes suggested in the merge request, we would certainly be glad to help.
    Thanks in advance!

  • Comment 24 days ago →
    🇫🇷France dydave
  • Comment 22 days ago →
    dgwolf

    Thanks a lot, @dydave! Please excuse the delayed answer. I'm glad you fixed this - your patch for admin_toolbar_content works very well here, and I wouldn't have been able to contribute to it.

  • Comment 21 days ago →
    🇧🇪Belgium kriboogh
  • Comment 21 days ago →
    🇫🇷France dydave

    Thanks a lot @dgwolf for the prompt and positive feedback!

    No problem at all 👌
    Thanks a lot for confirming the patch worked as expected, fixed the issue and we're very happy the changes worked fine.🙂

    Since Kris (@kriboogh), the maintainer of the admin_toolbar_content module merged the patch and released a new version of the module, we should be able to consider this issue Fixed for now.

    Thanks a lot to Kris for moving on this so quickly: I certainly didn't expect his reply to be so quick 😅

    Feel free to let us know if you encounter any other issues or would have any questions on the module in general, we would certainly be glad to help.
    Thanks in advance!

  • Comment 7 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024