matcher-pattern-deprecated-attributes-class-key ckeditor warnings

Created on 3 October 2023, 9 months ago

Updated 13 December 2023, 7 months ago

Ckeditor5 throws the matcher-pattern-deprecated-attributes-class-key ckeditor warning whenever the class attribute is enabled in the text format settings and a and a ckeditor5 with that format containing anchor tags is opened:

On vanilla D10

Enable editor_advanced_link
Enable the class attribute of the advanved link settings on the text format configuration form
Create a content of a type containing any longtext field that's using ckeditor5 (for example body)
In the longtext field add some anchor tags via the link toolbar button
Save the content and re-visit the edit form
Open the console and see the warnings mentioned above, one for each anchor tag

Use the classes property instead of a class attribute in the upcast converter.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

s_leu

Live updates comments and jobs are added and updated live.

Merge Requests

Issue created by @s_leu
Merge request !13Issue #3280990 by DuaelFr: test that the fields are available according to the... → (Open) created by s_leu
Comment 9 months ago →
s_leu
Status changed to Needs review 9 months ago5:00am 3 October 2023
Comment 9 months ago →
s_leu
Comment 9 months ago →
s_leu
Status changed to Needs work 9 months ago12:54pm 10 October 2023
Comment 9 months ago →
🇺🇦Ukraine vselivanov Kyiv, Ukraine
Hi @s_leu!
Thank you for work with this warnings.

But we should create a merge request to 2.x branch - not 8.x-1.x.
So we need only this commit

Only from this commit I created a patch that works good with the latest Drupal 10.1.5, CKEditor5 and Editor Advanced Link 2.2.4 release.
Status changed to Needs review 7 months ago2:28pm 13 December 2023
Comment 7 months ago →
s_leu

Production build 0.69.0 2024