Move toolbar integration into submodule.

trackleft2 → changed the visibility of the branch 4.x to hidden.

At the moment, when I enable the gin_toolbar module without the gin them being enabled the javascript breaks because the toolbar id changes from toolbar-bar to gin-toolbar-bar.

Additionally, when enabling the submodule the "default" environment indicator appears.

What should we do about the toolbar integration setting? I think if the environment_indicator_toolbar submodule is enabled, the default indicator should be disabled to keep existing functionality.

In the database update, we should check whether the toolbar module is enabled before enabling the environment_indicator_toolbar submodule. If toolbar is not enabled, then environment_indicator_toolbar should not be enabled.

My reasoning:

1. If the toolbar_integration config is set to ["toolbar" => "toolbar"] but the toolbar module isn’t enabled, then enabling environment_indicator_toolbar would result in a change in functionality: it would add the environment indicator to the toolbar (instead of #page_top) and also change the color of the toolbar. This could be unexpected or undesired.
2. There’s also a risk in the opposite direction: since the libraries have changed, someone may be depending on the old toolbar-related libraries even if the toolbar integration option is not selected. In this case, the module will no longer work for them, and a new issue should be created for an additional integration.

To avoid introducing unexpected behavior, we should only enable environment_indicator_toolbar if the toolbar module is already enabled.

trackleft2 → changed the visibility of the branch 3484735-move-toolbar-integration to hidden.

PHPUnit test broken

trackleft2 → closed merge request !76

Automatically closed - issue fixed for 2 weeks with no activity.