- Status changed to Postponed: needs info
about 10 hours ago 12:23am 28 June 2025
i'm checking out the latest release 8.x-3.0-alpha4 (and dev) and notice that this commit https://git.drupalcode.org/project/quicktabs/commit/fb696fe from #2909326: Empty Views Tabs still being rendered → is causing views to return empty if they require an argument.
The call to views_get_view_result() is not passing the arguments. The problem is views_get_view_result() wants the arguments as individual variables passed on the end of the function ($vid, $display, $arg1, $arg2, etc), not in an array as we have it. Unless I'm missing something, I'm not sure we can pass along these variables using that function.
Create a new method in ViewContent.php that duplicates the logic of views_get_view_result() but allows the variables to be passed in an array. Maybe something like viewIsEmpty($vid, $display, $args); ?
Does that make sense or is there a better way to do this?
Needs work
4.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.