🇬🇧United Kingdom @globexplorer

Account created on 27 October 2009, about 15 years ago
#

Recent comments

🇬🇧United Kingdom globexplorer

Fixed also with the following patch file.

🇬🇧United Kingdom globexplorer

globexplorer changed the visibility of the branch 3.0.x to hidden.

🇬🇧United Kingdom globexplorer

globexplorer changed the visibility of the branch 3490106-pagecache-fix to hidden.

🇬🇧United Kingdom globexplorer

globexplorer changed the visibility of the branch dev-3490106-pagecache-fix to hidden.

🇬🇧United Kingdom globexplorer

Thank you @oleksandr.s! I will remove the comment dependency from the config and once done give you credit for it.

🇬🇧United Kingdom globexplorer

Thanks @oleksandr.s! The problem here is, that the scorm field in that version can only be attached to entities of type node. We have to change some other bits in code and in database table to address this properly. The code change here would be not enough. Furthermore using layout builder with no node in route would that not be the logical next problem. Once we addressed all relying issues I will credit you for that issue.

🇬🇧United Kingdom globexplorer

Hi @oleksandr.s!

I think It would be better to remove the route match service at all. The node object can be retrieved from the fromatter ->getEntity() method itself.

see here:

    // Read the entity id from url
    $node = $items->getEntity();
    if ($node instanceof NodeInterface) {
      $nid = $node->id();
    }
🇬🇧United Kingdom globexplorer

This means that you have still meta data for entity in your config but the code has gone.

🇬🇧United Kingdom globexplorer

Fixed with Issue #3451617.

🇬🇧United Kingdom globexplorer

Fixed with the following patch for 11.11.x

Production build 0.71.5 2024